LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Documentation: gpio: remove duplicated lines
@ 2019-05-10  9:03 Luca Ceresoli
  2019-05-10 10:15 ` Bartosz Golaszewski
  2019-05-24 11:27 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Luca Ceresoli @ 2019-05-10  9:03 UTC (permalink / raw)
  To: linux-gpio
  Cc: Luca Ceresoli, Linus Walleij, Bartosz Golaszewski,
	Jonathan Corbet, linux-kernel, linux-doc

The 'default (active high)' lines are repeated twice. Avoid people stare at
their screens looking for differences.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 Documentation/driver-api/gpio/consumer.rst | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/driver-api/gpio/consumer.rst b/Documentation/driver-api/gpio/consumer.rst
index 5e4d8aa68913..23d68c321c5c 100644
--- a/Documentation/driver-api/gpio/consumer.rst
+++ b/Documentation/driver-api/gpio/consumer.rst
@@ -283,8 +283,6 @@ To summarize::
   gpiod_set_value(desc, 1);          default (active high)  high
   gpiod_set_value(desc, 0);          active low             high
   gpiod_set_value(desc, 1);          active low             low
-  gpiod_set_value(desc, 0);          default (active high)  low
-  gpiod_set_value(desc, 1);          default (active high)  high
   gpiod_set_value(desc, 0);          open drain             low
   gpiod_set_value(desc, 1);          open drain             high impedance
   gpiod_set_value(desc, 0);          open source            high impedance
-- 
2.21.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: gpio: remove duplicated lines
  2019-05-10  9:03 [PATCH] Documentation: gpio: remove duplicated lines Luca Ceresoli
@ 2019-05-10 10:15 ` Bartosz Golaszewski
  2019-05-24 11:27 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2019-05-10 10:15 UTC (permalink / raw)
  To: Luca Ceresoli; +Cc: linux-gpio, Linus Walleij, Jonathan Corbet, LKML, linux-doc

pt., 10 maj 2019 o 11:03 Luca Ceresoli <luca@lucaceresoli.net> napisał(a):
>
> The 'default (active high)' lines are repeated twice. Avoid people stare at
> their screens looking for differences.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>  Documentation/driver-api/gpio/consumer.rst | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/driver-api/gpio/consumer.rst b/Documentation/driver-api/gpio/consumer.rst
> index 5e4d8aa68913..23d68c321c5c 100644
> --- a/Documentation/driver-api/gpio/consumer.rst
> +++ b/Documentation/driver-api/gpio/consumer.rst
> @@ -283,8 +283,6 @@ To summarize::
>    gpiod_set_value(desc, 1);          default (active high)  high
>    gpiod_set_value(desc, 0);          active low             high
>    gpiod_set_value(desc, 1);          active low             low
> -  gpiod_set_value(desc, 0);          default (active high)  low
> -  gpiod_set_value(desc, 1);          default (active high)  high
>    gpiod_set_value(desc, 0);          open drain             low
>    gpiod_set_value(desc, 1);          open drain             high impedance
>    gpiod_set_value(desc, 0);          open source            high impedance
> --
> 2.21.0
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: gpio: remove duplicated lines
  2019-05-10  9:03 [PATCH] Documentation: gpio: remove duplicated lines Luca Ceresoli
  2019-05-10 10:15 ` Bartosz Golaszewski
@ 2019-05-24 11:27 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-05-24 11:27 UTC (permalink / raw)
  To: Luca Ceresoli
  Cc: open list:GPIO SUBSYSTEM, Bartosz Golaszewski, Jonathan Corbet,
	linux-kernel, Linux Doc Mailing List

On Fri, May 10, 2019 at 11:03 AM Luca Ceresoli <luca@lucaceresoli.net> wrote:

> The 'default (active high)' lines are repeated twice. Avoid people stare at
> their screens looking for differences.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

Patch applied with Bartosz's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-24 11:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-10  9:03 [PATCH] Documentation: gpio: remove duplicated lines Luca Ceresoli
2019-05-10 10:15 ` Bartosz Golaszewski
2019-05-24 11:27 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).