From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F79C4338F for ; Wed, 11 Aug 2021 13:10:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42FAD60FC0 for ; Wed, 11 Aug 2021 13:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbhHKNK1 (ORCPT ); Wed, 11 Aug 2021 09:10:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbhHKNKX (ORCPT ); Wed, 11 Aug 2021 09:10:23 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 551E3C061765 for ; Wed, 11 Aug 2021 06:09:59 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id n7so4572691ljq.0 for ; Wed, 11 Aug 2021 06:09:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=30PrYrxRiTwRaXmvYCFwrXC2WmCVC7G1BrqAmcqOYeY=; b=n2GGSdKDAmxJtzoGrNbBf1OOsA7noQcWb75rHS6OthmG3FML+dYKyMj7iACezQPVsN Qx0aMb58i9l9GA0oRZyUvGPZcJSSK1hpfJ/ON4pGFp6DDrX/AXcmnQkvOAPfHvG3pFgw fO1Hj8dmtpvuCzCmLP8aymxRvC1QCHhneOnw0Qo5K6Xz05q+1/Zwi3bp31xpJ3lt+Oqy cRC35o7o7FV94oERHypuhXEV11Yh4TwcDu2EKcMykng0RyvdIK3LryhHEQTOMkOU1lB9 FfH0HZOWMGDtW4shsRKSrUqdcbFpvstVZdTHR8B/aK9apTDvAwfIKrAcCEZ5B8Nb5YxT FfmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=30PrYrxRiTwRaXmvYCFwrXC2WmCVC7G1BrqAmcqOYeY=; b=p9T1Dm1c9LHO3FEQNKSKvm9TeIJAbj1iLSco+5oTPgwCTc9fujb9l0N5judKR2fDvA BSNeM+TnPlYdLNllGkRU99uGlsOOMoQtstJ8uj+0RlZg/lqJMkklhnzWce2AwHHjpgwt zo2tDvmW9shADs06aHDD+1bzWSeVx1gk8ZZMAPXiEZV36lpcGra/KSdIxGdMrzJoQhjf qf7uua7efVuSti0S/63finVgrf0rcFLejxwl7SF18gKFiYagIsf0u39TxShFSxdqdBHs maa8JnqPBytuyEKABOPxDdrch+MmDG+XromCrOJ8D7Men5yXRtCKM+nBXQ1UaYVltm0V HS6g== X-Gm-Message-State: AOAM532XByGlvYGzPsVkGjehPbyFxmlXkLddLeIhBjr72ysH238PrmAS sa1bU4rVdxgEnUSEjNq6f4ft5YCOQhy88C/Ls5ZeIg== X-Google-Smtp-Source: ABdhPJwqZ1Exlivd3XmoXAPJSzPqRbycJrfGC+vuwlmSgIK27TRACmN2JRpVppF8VLC5I1VQmQqJxwjg4Jor2IR1lnw= X-Received: by 2002:a2e:a231:: with SMTP id i17mr12749238ljm.467.1628687396439; Wed, 11 Aug 2021 06:09:56 -0700 (PDT) MIME-Version: 1.0 References: <20210729071905.3235953-1-yangyingliang@huawei.com> In-Reply-To: <20210729071905.3235953-1-yangyingliang@huawei.com> From: Linus Walleij Date: Wed, 11 Aug 2021 15:09:45 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: zynqmp: Drop pinctrl_unregister for devm_ registered device To: Yang Yingliang Cc: linux-kernel , Michal Simek , Sai Krishna Potthuri Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 9:12 AM Yang Yingliang wrote: > It's not necessary to unregister pin controller device registered > with devm_pinctrl_register() and using pinctrl_unregister() leads > to a double free. > > Fixes: fa99e7013827 ("pinctrl: zynqmp: some code cleanups") > Signed-off-by: Yang Yingliang Patch applied! Yours, Linus Walleij