LKML Archive on
help / color / mirror / Atom feed
From: Linus Walleij <>
To: Guenter Roeck <>
Cc: Eric Anholt <>, David Airlie <>,
	Daniel Vetter <>,
	"open list:DRM PANEL DRIVERS" <>,
	"" <>
Subject: Re: [PATCH] drm/pl111: Initialize clock spinlock early
Date: Wed, 15 May 2019 00:20:59 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, May 13, 2019 at 4:46 PM Guenter Roeck <> wrote:

> The following warning is seen on systems with broken clock divider.
> INFO: trying to register non-static key.
> the code is fine but needs lockdep annotation.
> turning off the locking correctness validator.
> CPU: 0 PID: 1 Comm: swapper Not tainted 5.1.0-09698-g1fb3b52 #1
> Hardware name: ARM Integrator/CP (Device Tree)
> [<c0011be8>] (unwind_backtrace) from [<c000ebb8>] (show_stack+0x10/0x18)
> [<c000ebb8>] (show_stack) from [<c07d3fd0>] (dump_stack+0x18/0x24)
> [<c07d3fd0>] (dump_stack) from [<c0060d48>] (register_lock_class+0x674/0x6f8)
> [<c0060d48>] (register_lock_class) from [<c005de2c>]
>         (__lock_acquire+0x68/0x2128)
> [<c005de2c>] (__lock_acquire) from [<c0060408>] (lock_acquire+0x110/0x21c)
> [<c0060408>] (lock_acquire) from [<c07f755c>] (_raw_spin_lock+0x34/0x48)
> [<c07f755c>] (_raw_spin_lock) from [<c0536c8c>]
>         (pl111_display_enable+0xf8/0x5fc)
> [<c0536c8c>] (pl111_display_enable) from [<c0502f54>]
>         (drm_atomic_helper_commit_modeset_enables+0x1ec/0x244)
> Since commit eedd6033b4c8 ("drm/pl111: Support variants with broken clock
> divider"), the spinlock is not initialized if the clock divider is broken.
> Initialize it earlier to fix the problem.
> Fixes: eedd6033b4c8 ("drm/pl111: Support variants with broken clock divider")
> Cc: Linus Walleij <>
> Signed-off-by: Guenter Roeck <>

Applied to drm-misc-next-fixes and pushed.

Out of curiosity: do you have a "real" Integrator/CP or is this

Linus Walleij

  reply	other threads:[~2019-05-14 22:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 14:46 Guenter Roeck
2019-05-14 22:20 ` Linus Walleij [this message]
2019-05-15  1:05   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] drm/pl111: Initialize clock spinlock early' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).