LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] pinctrl: falcon: fix syntax error
@ 2020-03-05 18:22 Mathias Kresin
  2020-03-05 19:11 ` Langer, Thomas
  2020-03-09  9:28 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Mathias Kresin @ 2020-03-05 18:22 UTC (permalink / raw)
  To: linus.walleij; +Cc: linux-gpio, linux-kernel, stable

Add the missing semicolon after of_node_put to get the file compiled.

Fixes: f17d2f54d36d ("pinctrl: falcon: Add of_node_put() before return")
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Mathias Kresin <dev@kresin.me>
---
 drivers/pinctrl/pinctrl-falcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-falcon.c b/drivers/pinctrl/pinctrl-falcon.c
index a454f57c264e..62c02b969327 100644
--- a/drivers/pinctrl/pinctrl-falcon.c
+++ b/drivers/pinctrl/pinctrl-falcon.c
@@ -451,7 +451,7 @@ static int pinctrl_falcon_probe(struct platform_device *pdev)
 		falcon_info.clk[*bank] = clk_get(&ppdev->dev, NULL);
 		if (IS_ERR(falcon_info.clk[*bank])) {
 			dev_err(&ppdev->dev, "failed to get clock\n");
-			of_node_put(np)
+			of_node_put(np);
 			return PTR_ERR(falcon_info.clk[*bank]);
 		}
 		falcon_info.membase[*bank] = devm_ioremap_resource(&pdev->dev,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] pinctrl: falcon: fix syntax error
  2020-03-05 18:22 [PATCH] pinctrl: falcon: fix syntax error Mathias Kresin
@ 2020-03-05 19:11 ` Langer, Thomas
  2020-03-09  9:28 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Langer, Thomas @ 2020-03-05 19:11 UTC (permalink / raw)
  To: Mathias Kresin, linus.walleij; +Cc: linux-gpio, linux-kernel, stable



> -----Original Message-----
> From: linux-gpio-owner@vger.kernel.org <linux-gpio-
> owner@vger.kernel.org> On Behalf Of Mathias Kresin
> Sent: Donnerstag, 5. März 2020 19:23
> To: linus.walleij@linaro.org
> Cc: linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org;
> stable@vger.kernel.org
> Subject: [PATCH] pinctrl: falcon: fix syntax error
> 
> Add the missing semicolon after of_node_put to get the file compiled.
> 
> Fixes: f17d2f54d36d ("pinctrl: falcon: Add of_node_put() before
> return")
> Cc: stable@vger.kernel.org # v5.4+
> Signed-off-by: Mathias Kresin <dev@kresin.me>

Acked-by: Thomas Langer <thomas.langer@intel.com>

> ---
>  drivers/pinctrl/pinctrl-falcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-falcon.c
> b/drivers/pinctrl/pinctrl-falcon.c
> index a454f57c264e..62c02b969327 100644
> --- a/drivers/pinctrl/pinctrl-falcon.c
> +++ b/drivers/pinctrl/pinctrl-falcon.c
> @@ -451,7 +451,7 @@ static int pinctrl_falcon_probe(struct
> platform_device *pdev)
>  		falcon_info.clk[*bank] = clk_get(&ppdev->dev, NULL);
>  		if (IS_ERR(falcon_info.clk[*bank])) {
>  			dev_err(&ppdev->dev, "failed to get clock\n");
> -			of_node_put(np)
> +			of_node_put(np);
>  			return PTR_ERR(falcon_info.clk[*bank]);
>  		}
>  		falcon_info.membase[*bank] = devm_ioremap_resource(&pdev-
> >dev,
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: falcon: fix syntax error
  2020-03-05 18:22 [PATCH] pinctrl: falcon: fix syntax error Mathias Kresin
  2020-03-05 19:11 ` Langer, Thomas
@ 2020-03-09  9:28 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-03-09  9:28 UTC (permalink / raw)
  To: Mathias Kresin; +Cc: open list:GPIO SUBSYSTEM, linux-kernel, stable

On Thu, Mar 5, 2020 at 7:22 PM Mathias Kresin <dev@kresin.me> wrote:

> Add the missing semicolon after of_node_put to get the file compiled.
>
> Fixes: f17d2f54d36d ("pinctrl: falcon: Add of_node_put() before return")
> Cc: stable@vger.kernel.org # v5.4+
> Signed-off-by: Mathias Kresin <dev@kresin.me>

Patch applied for fixes with Thomas Ack.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-09  9:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 18:22 [PATCH] pinctrl: falcon: fix syntax error Mathias Kresin
2020-03-05 19:11 ` Langer, Thomas
2020-03-09  9:28 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).