LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: ocelot: fix gpio direction
Date: Mon, 26 Mar 2018 11:05:25 +0200 [thread overview]
Message-ID: <CACRpkdbEWdo6UNL2HSzvvszQZjYnyYTOuWQzkmqSw=CvpGYhOw@mail.gmail.com> (raw)
In-Reply-To: <20180322123500.2379-1-alexandre.belloni@bootlin.com>
On Thu, Mar 22, 2018 at 1:35 PM, Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> Bits have to be cleared in DEVCPU_GCB:GPIO:GPIO_OE for input and set for
> output. ocelot_gpio_set_direction() got it wrong and this went unnoticed
> when the driver was reworked.
>
> Reported-by: Gregory Clement <gregory.clement@bootlin.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Patch applied.
Yours,
Linus Walleij
prev parent reply other threads:[~2018-03-26 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 12:35 Alexandre Belloni
2018-03-22 15:29 ` Gregory CLEMENT
2018-03-26 9:05 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdbEWdo6UNL2HSzvvszQZjYnyYTOuWQzkmqSw=CvpGYhOw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] pinctrl: ocelot: fix gpio direction' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).