LKML Archive on
help / color / mirror / Atom feed
From: Linus Walleij <>
To: Michal Simek <>
Cc: "" <>,
	Michal Simek <>,
	Steffen Trumtrar <>,
	Peter Crosthwaite <>,
	"open list:GPIO SUBSYSTEM" <>,
	Rob Herring <>,
	Linux ARM <>
Subject: Re: [PATCH] gpio: zynq: Setup chip->base based on alias ID
Date: Thu, 26 Apr 2018 15:08:24 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Apr 11, 2018 at 3:55 PM, Michal Simek <> wrote:

Thanks for your patch!

> In past Xilinx gpio-zynq driver was setting up gpio chip->base as 0
> which was chagned to autodetection when driver was upstreamed. Older
> systems, which were using this old version, setup SW stack which expects
> zynq gpio base as 0 and right now there is no way how to set this up.
> The patch is adding an option to setup chip->base based on aliases which
> is something what some other drivers are doing too.
> It means when gpio0 alias is setup then chip->base is 0. When gpio alias
> is not setup gpiochip_find_base() set it up properly which is current
> behavior.
> Signed-off-by: Michal Simek <>

In general, we stopped any controlling of the GPIO base.

Also this use would have to be OK with the DT maintainers
as I never saw this use of alias before.

Please describe the use case for this.

The only use case which I can think about is userspace sysfs
and then I would really like to know why these userspace
users cannot use the character device that is nowadays
supported by libgpiod and there is even patches for some
IoT libraries to use it. The character device makes the
GPIO Linux "base" irrelevant for userspace.

GPIO sysfs is deprecated and moved to the obsolete ABI.

If there are legacy applications that use this I would have
to consider it, but since this has been -1 since the driver
was merged I find that unlikely.

Linus Walleij

  reply	other threads:[~2018-04-26 13:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 13:55 Michal Simek
2018-04-26 13:08 ` Linus Walleij [this message]
2018-04-26 13:35   ` Michal Simek
2018-05-02 10:10     ` Linus Walleij
2018-05-02 10:15       ` Michal Simek
2018-05-02 13:01         ` Linus Walleij
2018-05-02 13:41           ` Michal Simek
2018-05-02 13:56             ` Linus Walleij
2018-05-02 14:19               ` Michal Simek
2018-05-15 13:26                 ` Michal Simek
2018-05-23  9:44                   ` Linus Walleij
2018-05-23 10:26                     ` Michal Simek
2018-05-23  9:42                 ` Linus Walleij
2018-05-23 10:17                   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] gpio: zynq: Setup chip->base based on alias ID' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).