From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A3AC4338F for ; Wed, 11 Aug 2021 08:32:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DA1160F41 for ; Wed, 11 Aug 2021 08:32:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236050AbhHKIcl (ORCPT ); Wed, 11 Aug 2021 04:32:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233167AbhHKIcj (ORCPT ); Wed, 11 Aug 2021 04:32:39 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1099EC0613D5 for ; Wed, 11 Aug 2021 01:32:16 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id y34so4016376lfa.8 for ; Wed, 11 Aug 2021 01:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T9aF/gnHHaozYj2J+OBaspaiiV6uiEkY/GBIP7m0gEg=; b=z4zPOj2oXB+m27UeJcQn5BVLsxsB4z1KOcQYkV7Zp4KvMRcbXTwGaQYgvfjzMX/nBU +zmL0eQOyKOXcbZUzpKCJJfPmbA62iwzKwBm+4YtiuzZjzMDYUtdFO0Mz87QkQPr38YJ fggNcHhRGF/BagSG37jlWaIkXwYqR0dnF13GLl5azCiqyXmrLFlj3Tzz5mag8r20A6HE pZ7rAO2PUBHurc0seOXsZIH1lLrsbGPHPpF9eFSVOwVG8GzQQjJDJ79SKGk+YdBFO9Gx 3MZeVhJt+5R2p2mJ8v9vcjavRhrjmWHrZ+uhVc8cVKFVyzaTQfCwk2AHhFi9e1n9y8UE jwsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T9aF/gnHHaozYj2J+OBaspaiiV6uiEkY/GBIP7m0gEg=; b=c6o1WoQgcAfSLiWgda6FBKoDun3dnreWcNN6gs2AVEvaLIbMMJCeFJUcXHd/IThQNd S5z7GRLGsQx8fkGs599NFQw1JECXDPa2IvxbfxoQwroiXGAhT3/ARVkIZ51RPLLPwf5b EWUMxsotLeGHPLifA9VoZjEoVUkNH2oCqBM5XorIGhAF8KUAc9UZ0ObuX5LOzFaLzfWf UCNPhefUMOfODAoWEsl/ZrnmDeHv7SNWEc5AeSpN7cG6MHG3yT8TYLNLtIdwJlNBm8Z5 SZc3fihhmbB0gCQJNvxNiI4OeA6U6lQg+BO3wjDDIykEiq083oh3vIaZJRSUBJtMsRDO X+Xg== X-Gm-Message-State: AOAM531Bobo50j5S+SSNoKpqr2SiZzjBgZQVo/5vPDdNTZdiXTMfjCkU GOgEa4aWqpUcEMLDADOnT36gKjLkdHmqyVA5lc84dg== X-Google-Smtp-Source: ABdhPJx8KOnvL7KNjPPz1PGddRFRscqa0/aQu7hNC6SM9IIiyOqA7hHEP9AiCoar+a37Et8CsHj/YEfe9PFf6cIfeKQ= X-Received: by 2002:a19:c7cd:: with SMTP id x196mr24373795lff.465.1628670734307; Wed, 11 Aug 2021 01:32:14 -0700 (PDT) MIME-Version: 1.0 References: <20210726013345.1634442-1-jay.xu@rock-chips.com> In-Reply-To: <20210726013345.1634442-1-jay.xu@rock-chips.com> From: Linus Walleij Date: Wed, 11 Aug 2021 10:32:03 +0200 Message-ID: Subject: Re: [PATCH v7 0/9] gpio-rockchip driver To: Jianqun Xu Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Bartosz Golaszewski , Rob Herring , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/Rockchip SoC..." , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 26, 2021 at 3:34 AM Jianqun Xu wrote: > Separate gpio driver from pinctrl driver, and support gpio v2 controller. Mostly looks good, but waiting for a respin to address Bartosz comments on patch 5. Yours, Linus Walleij