LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Corentin Labbe <clabbe@baylibre.com>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	SoC Team <soc@kernel.org>,
	Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] ARM: gemini: add device tree for ssi1328
Date: Fri, 23 Jul 2021 12:38:36 +0200	[thread overview]
Message-ID: <CACRpkdb_jpK77w5O-SW1PcDU-SYyrXCFaMgDhMaKa1MiL5HOEA@mail.gmail.com> (raw)
In-Reply-To: <20210712201125.GA2401230@robh.at.kernel.org>

Thanks Rob,

I fixed some issues while applying.

On Mon, Jul 12, 2021 at 10:11 PM Rob Herring <robh@kernel.org> wrote:

> > +     model = "SSI 1328";
> > +     compatible = "ssi,1328", "cortina,gemini";
>
> Where's ssi,1328 documented?

I'll take a sweep and add all of the new machines.

> > +     chosen {
> > +             bootargs = "console=ttyS0,19200n8 initrd=0x900000,9M";
> > +             stdout-path = &uart0;
>
> Don't need both 'console' and stdout-path. (console should be removed)

How does one specify a default baudrate using that method?

Yours,
Linus Walleij

  reply	other threads:[~2021-07-23 10:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 20:55 [PATCH v2 0/5] ARM: gemini: add two more board Corentin Labbe
2021-06-18 20:55 ` [PATCH v2 1/5] ARM: dts: gemini: add labels for USB, IDE, flash and ethernet Corentin Labbe
2021-06-18 20:55 ` [PATCH v2 2/5] dt-bindings: add vendor prefix for edimax Corentin Labbe
2021-07-12 20:11   ` Rob Herring
2021-06-18 20:55 ` [PATCH v2 3/5] dt-bindings: add vendor prefix for ssi Corentin Labbe
2021-07-12 20:11   ` Rob Herring
2021-06-18 20:55 ` [PATCH v2 4/5] ARM: gemini: add device tree for edimax NS2502 Corentin Labbe
2021-06-18 20:55 ` [PATCH v2 5/5] ARM: gemini: add device tree for ssi1328 Corentin Labbe
2021-07-12 20:11   ` Rob Herring
2021-07-23 10:38     ` Linus Walleij [this message]
2021-07-23 10:34 ` [PATCH v2 0/5] ARM: gemini: add two more board Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdb_jpK77w5O-SW1PcDU-SYyrXCFaMgDhMaKa1MiL5HOEA@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=arnd@arndb.de \
    --cc=clabbe@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robh@kernel.org \
    --cc=soc@kernel.org \
    --cc=ulli.kroll@googlemail.com \
    --subject='Re: [PATCH v2 5/5] ARM: gemini: add device tree for ssi1328' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).