LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dmitry Vyukov <dvyukov@google.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: syzbot <syzbot+87cfa083e727a224754b@syzkaller.appspotmail.com>,
avagin <avagin@openvz.org>, David Miller <davem@davemloft.net>,
Ding Tianhong <dingtianhong@huawei.com>,
Eric Dumazet <edumazet@google.com>,
"Reshetova, Elena" <elena.reshetova@intel.com>,
Jason Wang <jasowang@redhat.com>, KVM list <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Matthew Dawson <matthew@mjdsystems.ca>,
Ingo Molnar <mingo@kernel.org>, netdev <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
Al Viro <viro@zeniv.linux.org.uk>,
virtualization@lists.linux-foundation.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: KMSAN: uninit-value in _copy_to_iter (2)
Date: Thu, 7 Jun 2018 18:25:35 +0200 [thread overview]
Message-ID: <CACT4Y+btyLi+z09EO0JU-7AS_OfRbWiZvGn-KP9fndevh+xFNw@mail.gmail.com> (raw)
In-Reply-To: <20180607183627-mutt-send-email-mst@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]
On Thu, Jun 7, 2018 at 5:38 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> #syz test: https://github.com/google/kmsan.git/master d2d741e5d1898dfde1a75ea3d29a9a3e2edf0617
Hi Michael,
We need:
#syz test: https://github.com/google/kmsan.git master
here. Please see
https://github.com/google/syzkaller/blob/master/docs/syzbot.md#testing-patches
for more info.
Please also add the Reported-by tag when mailing the patch for review.
Thanks
> Subject: vhost: fix info leak
>
> Fixes: CVE-2018-1118
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index f0be5f35ab28..9beefa6ed1ce 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -2345,6 +2345,9 @@ struct vhost_msg_node *vhost_new_msg(struct vhost_virtqueue *vq, int type)
> struct vhost_msg_node *node = kmalloc(sizeof *node, GFP_KERNEL);
> if (!node)
> return NULL;
> +
> + /* Make sure all padding within the structure is initialized. */
> + memset(&node->msg, 0, sizeof node->msg);
> node->vq = vq;
> node->msg.type = type;
> return node;
>
> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/20180607183627-mutt-send-email-mst%40kernel.org.
> For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 518 bytes --]
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index f0be5f35ab28..9beefa6ed1ce 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -2345,6 +2345,9 @@ struct vhost_msg_node *vhost_new_msg(struct vhost_virtqueue *vq, int type)
struct vhost_msg_node *node = kmalloc(sizeof *node, GFP_KERNEL);
if (!node)
return NULL;
+
+ /* Make sure all padding within the structure is initialized. */
+ memset(&node->msg, 0, sizeof node->msg);
node->vq = vq;
node->msg.type = type;
return node;
next prev parent reply other threads:[~2018-06-07 16:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 16:56 syzbot
2018-04-25 19:19 ` syzbot
2018-06-07 15:38 ` Michael S. Tsirkin
2018-06-07 15:38 ` syzbot
2018-06-07 16:25 ` Dmitry Vyukov [this message]
2018-06-07 17:04 ` syzbot
2018-06-07 17:43 ` Al Viro
2018-06-07 17:59 ` Michael S. Tsirkin
2018-06-07 18:04 ` Al Viro
2018-06-07 19:29 ` Michael S. Tsirkin
2018-06-07 17:10 ` Michael S. Tsirkin
2018-06-07 17:31 ` syzbot
2018-04-27 15:45 ` [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node Kevin Easton
2018-04-27 16:05 ` Michael S. Tsirkin
2018-04-27 16:11 ` Dmitry Vyukov
2018-04-27 16:15 ` Michael S. Tsirkin
2018-04-27 16:25 ` Dmitry Vyukov
2018-04-27 16:29 ` Dmitry Vyukov
2018-04-27 19:36 ` Michael S. Tsirkin
2018-04-29 8:10 ` Dmitry Vyukov
2018-04-28 1:07 ` Kevin Easton
2018-04-28 1:51 ` Kevin Easton
2018-04-28 2:23 ` Jason Wang
2018-05-07 13:03 ` Michael S. Tsirkin
2018-05-07 13:12 ` Dmitry Vyukov
2018-05-08 8:27 ` Kevin Easton
2018-05-29 22:19 ` [net] " Guenter Roeck
2018-05-30 3:01 ` Michael S. Tsirkin
2018-05-30 3:42 ` Guenter Roeck
2018-06-04 12:34 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+btyLi+z09EO0JU-7AS_OfRbWiZvGn-KP9fndevh+xFNw@mail.gmail.com \
--to=dvyukov@google.com \
--cc=avagin@openvz.org \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=edumazet@google.com \
--cc=elena.reshetova@intel.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@mjdsystems.ca \
--cc=mingo@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+87cfa083e727a224754b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemb@google.com \
--subject='Re: KMSAN: uninit-value in _copy_to_iter (2)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).