LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ming Lei <ming.lei@canonical.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	Sasha Levin <sasha.levin@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blk-mq: Fix a recently introduced scsi-mq regression
Date: Thu, 29 Jan 2015 19:39:14 +0800	[thread overview]
Message-ID: <CACVXFVP0d=17wtH5hHP6oUtA_XZC8TmfhRvYZv_-Kug6=iMtbA@mail.gmail.com> (raw)
In-Reply-To: <54CA1929.8060903@sandisk.com>

Hi Bart,

On Thu, Jan 29, 2015 at 7:27 PM, Bart Van Assche
<bart.vanassche@sandisk.com> wrote:
> On 01/29/15 00:52, Ming Lei wrote:
>> On Thu, Jan 29, 2015 at 2:28 AM, Bart Van Assche
>> <bart.vanassche@sandisk.com> wrote:
>>> This patch fixes a use-after-free that was introduced via patch
>>> "blk-mq: fix hctx/ctx kobject use-after-free" (commit
>>> 76d697d10769; kernel v3.19-rc4) and fixes the following crash:
>>
>> Sorry, my fault, I shouldn't have linked mq's release with mq_kobj,
>> which may be released before running blk_cleanup_queue().
>>
>> Another approach may be to revert the faulty commit and release all
>> mq stuff in request queue's release handler(blk_release_queue)
>> which should be more safe and simple.
>
> Hello Ming,
>
> How important is the patch with commit ID 76d697d10769 ? Does it have to
> be included in kernel v3.19 or can it be postponed until kernel v3.19.1
> or kernel v3.19.2 ? If so, how about reverting that patch for kernel

The patch has been in linus tree, but it isn't marked as -stable.

> v3.19 and sending a reworked patch to Jens with a "Cc: stable" tag after
> the release of kernel v3.19 ? That last patch will then get included in
> a stable version of kernel v3.19.

Anyway, it need to be fixed, either reverted or a new patch.

I will post out one revert and another fix candidate, and let's
discuss further.


Thanks,
Ming Lei

      reply	other threads:[~2015-01-29 11:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 18:28 Bart Van Assche
2015-01-28 23:52 ` Ming Lei
2015-01-29 11:27   ` Bart Van Assche
2015-01-29 11:39     ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACVXFVP0d=17wtH5hHP6oUtA_XZC8TmfhRvYZv_-Kug6=iMtbA@mail.gmail.com' \
    --to=ming.lei@canonical.com \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@sandisk.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sasha.levin@oracle.com \
    --subject='Re: [PATCH] blk-mq: Fix a recently introduced scsi-mq regression' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).