LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Robert Foss <robert.foss@collabora.com>,
	David Airlie <airlied@linux.ie>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	"open list:VIRTIO GPU DRIVER" 
	<virtualization@lists.linux-foundation.org>,
	Gustavo Padovan <gustavo.padovan@collabora.com>,
	Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH 2/5] drm/virtio: add uapi for in and out explicit fences
Date: Tue, 30 Oct 2018 11:31:04 +0000	[thread overview]
Message-ID: <CACvgo50MK1jU0jKMCfZJQSaSmpQ8mmYj1=4GP2NQvM_DHOaW-Q@mail.gmail.com> (raw)
In-Reply-To: <20181030061127.hp4n2scw5f3j2rqq@sirius.home.kraxel.org>

HI Gerd,

On Tue, 30 Oct 2018 at 06:11, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
>   Hi,
>
> > The execbuffer IOCTL is now read-write to allow the userspace to read the
> > out-fence.
>
> >  #define DRM_IOCTL_VIRTGPU_EXECBUFFER \
> > -     DRM_IOW(DRM_COMMAND_BASE + DRM_VIRTGPU_EXECBUFFER,\
> > +     DRM_IOWR(DRM_COMMAND_BASE + DRM_VIRTGPU_EXECBUFFER,\
> >               struct drm_virtgpu_execbuffer)
>
> That changes the ioctl number and breaks the userspace api.
>
Have you looked at the drm_ioctl() implementation? AFAICT it
explicitly caters for this kind of changes.

-Emil

  reply	other threads:[~2018-10-30 11:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 18:37 [PATCH 0/5] virgl: fence fd support Robert Foss
2018-10-25 18:37 ` [PATCH 1/5] drm/virtio: add virtio_gpu_alloc_fence() Robert Foss
2018-10-31  9:38   ` Emil Velikov
2018-11-01 12:43     ` Robert Foss
2018-11-05  6:38       ` Gerd Hoffmann
2018-10-25 18:37 ` [PATCH 2/5] drm/virtio: add uapi for in and out explicit fences Robert Foss
2018-10-30  6:11   ` Gerd Hoffmann
2018-10-30 11:31     ` Emil Velikov [this message]
2018-10-30 13:52       ` Gerd Hoffmann
2018-10-30 15:48         ` Emil Velikov
2018-10-31  9:38   ` Emil Velikov
2018-11-01 12:56     ` Robert Foss
2018-11-02 13:34       ` Emil Velikov
2018-11-02 14:42         ` Robert Foss
2018-10-25 18:37 ` [PATCH 3/5] drm/virtio: add in-fences support for explicit synchronization Robert Foss
2018-10-31  9:38   ` Emil Velikov
2018-10-25 18:37 ` [PATCH 4/5] drm/virtio: add out-fences " Robert Foss
2018-10-31  9:39   ` Emil Velikov
2018-10-25 18:37 ` [PATCH 5/5] drm/virtio: bump driver version after explicit synchronization addition Robert Foss
2018-10-31  9:39   ` Emil Velikov
2018-10-31  9:45 ` [PATCH 0/5] virgl: fence fd support Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACvgo50MK1jU0jKMCfZJQSaSmpQ8mmYj1=4GP2NQvM_DHOaW-Q@mail.gmail.com' \
    --to=emil.l.velikov@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.velikov@collabora.com \
    --cc=gustavo.padovan@collabora.com \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.foss@collabora.com \
    --cc=virtualization@lists.linux-foundation.org \
    --subject='Re: [PATCH 2/5] drm/virtio: add uapi for in and out explicit fences' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).