[PATCH v3 0/6] KVM: nVMX: Enable nested apicv support.

[PATCH v3 0/6] KVM: nVMX: Enable nested apicv support.

[Wincy Van]

v1 ---> v2:
  Use spin lock to ensure vmcs12 is safe when doing nested
  posted interrupt delivery.

v2 ---> v3:
  1. Add a new field in nested_vmx to avoid the spin lock in v2.
  2. Drop send eoi to L1 when doing nested interrupt delivery.
  3. Use hardware MSR bitmap to enable nested virtualize x2apic
     mode.

Wincy Van (6):
  KVM: nVMX: Use hardware MSR bitmap
  KVM: nVMX: Enable nested virtualize x2apic mode.
  KVM: nVMX: Make nested control MSRs per-cpu.
  KVM: nVMX: Enable nested apic register virtualization.
  KVM: nVMX: Enable nested virtual interrupt delivery.
  KVM: nVMX: Enable nested posted interrupt processing.

 arch/x86/kvm/vmx.c |  570 +++++++++++++++++++++++++++++++++++++++++++---------
 1 files changed, 470 insertions(+), 100 deletions(-)

Re: [PATCH v3 0/6] KVM: nVMX: Enable nested apicv support.

[Paolo Bonzini]

On 24/01/2015 11:18, Wincy Van wrote:
> v2 ---> v3:
>   1. Add a new field in nested_vmx to avoid the spin lock in v2.
>   2. Drop send eoi to L1 when doing nested interrupt delivery.
>   3. Use hardware MSR bitmap to enable nested virtualize x2apic
>      mode.

I think the patches are mostly okay.  I made a few comments.

One of the things to do on top could be to avoid rebuilding the whole
vmcs02 on every entry.  Recomputing the MSR bitmap on every vmentry is
not particularly nice, for example.  It is not necessary unless the
execution controls have changed.

Paolo

Re: [PATCH v3 0/6] KVM: nVMX: Enable nested apicv support.

[Wincy Van]

On Wed, Jan 28, 2015 at 6:06 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 24/01/2015 11:18, Wincy Van wrote:
>> v2 ---> v3:
>>   1. Add a new field in nested_vmx to avoid the spin lock in v2.
>>   2. Drop send eoi to L1 when doing nested interrupt delivery.
>>   3. Use hardware MSR bitmap to enable nested virtualize x2apic
>>      mode.
>
> I think the patches are mostly okay.  I made a few comments.
>

Thank you, Paolo and Yang. I can't accomplish this without your help.

> One of the things to do on top could be to avoid rebuilding the whole
> vmcs02 on every entry.  Recomputing the MSR bitmap on every vmentry is
> not particularly nice, for example.  It is not necessary unless the
> execution controls have changed.

Indeed, I was planned to do that optimization after this patch set.


Thanks,
Wincy

>
> Paolo