LKML Archive on
help / color / mirror / Atom feed
From: Daniel Drake <>
To: Chris Chiu <>
Cc: Jes Sorensen <>,
	Kalle Valo <>,
	David Miller <>,
	linux-wireless <>,
	netdev <>,
	Linux Kernel <>,
	Linux Upstreaming Team <>,
	Larry Finger <>
Subject: Re: [RFC PATCH 2/2] rtl8xxxu: Add watchdog to update rate mask by signal strength
Date: Mon, 27 May 2019 10:40:49 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, May 27, 2019 at 12:38 AM Chris Chiu <> wrote:
> The -EBUSY is returned by the ieee80211_check_combinations() in the
> ieee80211_check_concurrent_iface() function which is invoked each time
> doing ieee80211_open().
> The ieee80211_check_combinations() returns the -EBUSY because of
> cfg80211_check_combinations() will iterate all interfaces of different types
> then checks the combination is valid or not, which in this case the number
> of interface combination accumulated by cfg80211_iter_sum_ifcombos is 0
> when I'm trying to bring up the second station interface.

Thanks for clarifying. I see, rtl8xxxu does not provide any
iface_combinations so the default is to reject parallel interfaces.

Given that we can now confidently say that multiple interfaces are not
supported, I think that inside rtl8xxxu_add_interface() you could
store a pointer to the vif inside the rtl8xxxu_priv structure (and
clear it in rtl8xxxu_remove_interface). Plus for clarity, add a
comment pointing out that only a single interface is supported, and
make rtl8xxxu_add_interface() acually fail if we already had a
non-NULL pointer stored in the priv structure.

Then you can simplify the patch to remove the ugly storing of vif
inside rtl8xxxu_watchdog. You can store the delayed_work in the main
priv struct too, dropping rtl8xxxu_watchdog altogether.


      reply	other threads:[~2019-05-27 16:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03  7:21 [RFC PATCH 0/2] Improve TX performance of RTL8723BU on rtl8xxxu driver Chris Chiu
2019-05-03  7:21 ` [RFC PATCH 1/2] rtl8xxxu: Add rate adaptive related data Chris Chiu
2019-05-03  7:49   ` Kalle Valo
2019-05-09  8:11   ` Daniel Drake
2019-05-09  9:29     ` Joe Perches
2019-05-03  7:21 ` [RFC PATCH 2/2] rtl8xxxu: Add watchdog to update rate mask by signal strength Chris Chiu
2019-05-09  8:11   ` Daniel Drake
2019-05-09  9:17     ` Chris Chiu
2019-05-09 11:24       ` Daniel Drake
2019-05-10  8:36         ` Chris Chiu
2019-05-21 18:38           ` Daniel Drake
2019-05-27  6:38             ` Chris Chiu
2019-05-27 16:40               ` Daniel Drake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [RFC PATCH 2/2] rtl8xxxu: Add watchdog to update rate mask by signal strength' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).