LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Doug Anderson <firstname.lastname@example.org>
To: Artur Petrosyan <Arthur.Petrosyan@synopsys.com>
Cc: "Minas Harutyunyan" <Minas.Harutyunyan@synopsys.com>,
"Felipe Balbi" <email@example.com>,
"Heiko Stübner" <firstname.lastname@example.org>,
"Alan Stern" <email@example.com>,
"Alexandru M Stan" <firstname.lastname@example.org>,
"open list:ARM/Rockchip SoC..."
"William Wu" <email@example.com>,
"Stefan Wahren" <firstname.lastname@example.org>,
"Randy Li" <email@example.com>, Chris <firstname.lastname@example.org>,
"Matthias Kaehlcke" <email@example.com>,
"Ryan Case" <firstname.lastname@example.org>,
"Amelie Delaunay" <email@example.com>,
"Julius Werner" <firstname.lastname@example.org>,
"Elaine Zhang" <email@example.com>,
"Greg Kroah-Hartman" <firstname.lastname@example.org>,
Subject: Re: [PATCH v2 1/5] usb: dwc2: bus suspend/resume for hosts with DWC2_POWER_DOWN_PARAM_NONE
Date: Fri, 3 May 2019 08:07:32 -0700 [thread overview]
Message-ID: <CAD=FV=V97+_cQ1aD=w_a3SifGOG3M5DPvcnvxYVUJMkX_WLTFg@mail.gmail.com> (raw)
On Fri, May 3, 2019 at 1:25 AM Artur Petrosyan
> On 5/2/2019 03:58, Doug Anderson wrote:
> > Hi,
> > On Wed, Apr 17, 2019 at 5:15 PM Douglas Anderson <email@example.com> wrote:
> >> This is an attempt to rehash commit 0cf884e819e0 ("usb: dwc2: add bus
> >> suspend/resume for dwc2") on ToT. That commit was reverted in commit
> >> b0bb9bb6ce01 ("Revert "usb: dwc2: add bus suspend/resume for dwc2"")
> >> because apparently it broke the Altera SOCFPGA.
> >> With all the changes that have happened to dwc2 in the meantime, it's
> >> possible that the Altera SOCFPGA will just magically work with this
> >> change now. ...and it would be good to get bus suspend/resume
> >> implemented.
> >> This change is a forward port of one that's been living in the Chrome
> >> OS 3.14 kernel tree.
> >> Signed-off-by: Douglas Anderson <firstname.lastname@example.org>
> >> ---
> >> This patch was last posted at:
> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.kernel.org_r_1446237173-2D15263-2D1-2Dgit-2Dsend-2Demail-2Ddianders-40chromium.org&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=9hPBFKCJ_nBjJhGVrrlYOeOQjP_HlVzYqrC_D7niMJI&m=7rxT8EFX9mqUDtTL4P7iuzYNsYROe9rxHGCresSKPTg&s=lTaNUA2XIYPat417fkd1A4Zpvb5eyYtTc1H_NIfW8Vw&e=
> >> ...and appears to have died the death of silence. Maybe it could get
> >> some bake time in linuxnext if we can't find any proactive testing?
> >> I will also freely admit that I don't know tons about the theory
> >> behind this patch. I'm mostly just re-hashing the original commit
> >> from Kever that was reverted since:
> >> * Turning on partial power down on rk3288 doesn't "just work". I
> >> don't get hotplug events. This is despite dwc2 auto-detecting that
> >> we are power optimized.
> >> * If we don't do something like this commit we don't get into as low
> >> of a power mode.
> > OK, I spent the day digging more into this patch to confirm that it's
> > really the right thing to do. ...and it still seems to be.
> > First off: I'm pretty sure the above sentence "If we don't do
> > something like this commit we don't get into as low of a power mode."
> > is totally wrong. Luckily it's "after the cut" and not part of the
> > commit message. Specifically I did a bunch of power testing and I
> > couldn't find any instance saving power after this patch.
> > ...but, then I looked more carefully at all the history of this
> > commit. I ended up at:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__chromium-2Dreview.googlesource.com_c_chromiumos_third-5Fparty_kernel_-2B_306265_&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=9hPBFKCJ_nBjJhGVrrlYOeOQjP_HlVzYqrC_D7niMJI&m=7rxT8EFX9mqUDtTL4P7iuzYNsYROe9rxHGCresSKPTg&s=LiyyIyaCPmr88nJeI7TCGtoJBFLRWir_reikYtAHHDw&e=
> Looking at this code review I see that this patch fixes whatever issues
> you have on Chrome OS 3.14. But your patch has landed on the top of
> latest Kernel version. With the latest version I think you would not
> have the regression issue.
> So you are fixing Chrome OS 3.14.
I'm confused why you ignored the rest of my email where I said I also
ported it to 4.19 (which, from a dwc2 host point of view, is pretty
much mainline) and saw that the patch was still needed.
next prev parent reply other threads:[~2019-05-03 15:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 0:13 [PATCH v2 0/5] USB: dwc2: Allow wakeup from suspend; enable for rk3288-veyron Douglas Anderson
2019-04-18 0:13 ` [PATCH v2 1/5] usb: dwc2: bus suspend/resume for hosts with DWC2_POWER_DOWN_PARAM_NONE Douglas Anderson
2019-04-29 8:43 ` Artur Petrosyan
2019-04-29 17:33 ` Doug Anderson
2019-04-30 6:05 ` Artur Petrosyan
2019-05-01 1:51 ` Doug Anderson
2019-05-03 8:20 ` Artur Petrosyan
2019-05-03 15:03 ` Doug Anderson
2019-05-07 7:26 ` Artur Petrosyan
2019-05-01 23:58 ` Doug Anderson
2019-05-03 8:25 ` Artur Petrosyan
2019-05-03 15:07 ` Doug Anderson [this message]
2019-05-07 7:05 ` Artur Petrosyan
2019-04-18 0:13 ` [PATCH v2 2/5] USB: Export usb_wakeup_enabled_descendants() Douglas Anderson
2019-04-18 0:13 ` [PATCH v2 3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB Douglas Anderson
2019-04-25 12:40 ` Felipe Balbi
2019-04-25 18:09 ` Doug Anderson
2019-04-25 19:58 ` Doug Anderson
2019-05-02 18:36 ` Doug Anderson
2019-04-30 1:23 ` Rob Herring
2019-04-30 5:25 ` Doug Anderson
2019-04-18 0:13 ` [PATCH v2 4/5] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled Douglas Anderson
2019-04-25 12:41 ` Felipe Balbi
2019-04-18 0:13 ` [PATCH v2 5/5] ARM: dts: rockchip: Allow wakeup from rk3288-veyron's dwc2 USB ports Douglas Anderson
2019-04-18 12:40 ` [PATCH v2 0/5] USB: dwc2: Allow wakeup from suspend; enable for rk3288-veyron Minas Harutyunyan
2019-04-18 15:54 ` Doug Anderson
2019-04-19 11:43 ` Artur Petrosyan
2019-04-19 16:44 ` Artur Petrosyan
2019-04-22 15:50 ` Artur Petrosyan
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH v2 1/5] usb: dwc2: bus suspend/resume for hosts with DWC2_POWER_DOWN_PARAM_NONE' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).