From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934022AbdKBBrn (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Nov 2017 21:47:43 -0400
Received: from mail-ua0-f194.google.com ([209.85.217.194]:48728 "EHLO
        mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752380AbdKBBrl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Nov 2017 21:47:41 -0400
X-Google-Smtp-Source: ABhQp+QSB84pHOLOQikMY04w5Zc+1Dd/AR/DmoU1i4/ICixlM5MR4OPjlhL6IdnCBcNhmxBTV7Ky8Gr2rZGvp0a5c/A=
MIME-Version: 1.0
In-Reply-To: <20171102123617.56364a21@canb.auug.org.au>
References: <20171102123617.56364a21@canb.auug.org.au>
From: Doug Anderson <dianders@chromium.org>
Date: Wed, 1 Nov 2017 18:47:39 -0700
X-Google-Sender-Auth: PdVihSHwKrrzy8iQfgXqtLo-EAM
Message-ID: <CAD=FV=VD2mgZQLS7q=iKzZOZ1_-FN1XR=gN8+60w_=zZJObVfA@mail.gmail.com>
Subject: Re: linux-next: build warning after merge of the mmc tree
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
        Linux-Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Shawn Lin <shawn.lin@rock-chips.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Wed, Nov 1, 2017 at 6:36 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Ulf,
>
> After merging the mmc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/linux/irqflags.h:14:0,
>                  from arch/arm/include/asm/bitops.h:27,
>                  from include/linux/bitops.h:37,
>                  from include/linux/kernel.h:10,
>                  from include/asm-generic/bug.h:15,
>                  from arch/arm/include/asm/bug.h:59,
>                  from include/linux/bug.h:4,
>                  from include/linux/thread_info.h:11,
>                  from include/asm-generic/current.h:4,
>                  from ./arch/arm/include/generated/asm/current.h:1,
>                  from include/linux/sched.h:11,
>                  from include/linux/blkdev.h:4,
>                  from drivers/mmc/host/dw_mmc.c:14:
> drivers/mmc/host/dw_mmc.c: In function 'dw_mci_set_drto':
> include/linux/typecheck.h:11:18: warning: comparison of distinct pointer types lacks a cast
>   (void)(&__dummy == &__dummy2); \
>                   ^
> include/linux/spinlock.h:221:3: note: in expansion of macro 'typecheck'
>    typecheck(unsigned long, flags); \
>    ^
> include/linux/spinlock.h:346:2: note: in expansion of macro 'raw_spin_lock_irqsave'
>   raw_spin_lock_irqsave(spinlock_check(lock), flags); \
>   ^
> drivers/mmc/host/dw_mmc.c:1953:2: note: in expansion of macro 'spin_lock_irqsave'
>   spin_lock_irqsave(&host->irq_lock, irqflags);
>   ^
>
> Introduced by commit
>
>   80a2a5a7745b ("mmc: dw_mmc: Cleanup the DTO timer like the CTO one")

Yes, the 0-day bot already complained about this.  The short answer is
that Ulf kindly volunteered to manually fix up my patch series where I
had introduced a variable in the wrong patch.  ...but in doing so he
introduced a small bug.

It should be very easy to fix.  Just need to change irqflags from
"unsigned int" to "unsigned long".


-Doug