LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>,
	me@tobin.cc, Joe Perches <joe@perches.com>,
	stable@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kdb: Fix btc (backtrace on each cpu) crash
Date: Wed, 31 Oct 2018 08:05:54 -0700	[thread overview]
Message-ID: <CAD=FV=W+NScZ8KCcBhULwmx3VMx0uUro=jKm7og9-OsRKmNdmA@mail.gmail.com> (raw)
In-Reply-To: <20181031115910.5bqgtnzf2zujnp5b@holly.lan>

Hi,

On Wed, Oct 31, 2018 at 4:59 AM Daniel Thompson
<daniel.thompson@linaro.org> wrote:
>
> On Tue, Oct 30, 2018 at 01:53:34PM -0700, Douglas Anderson wrote:
> > Typing 'btc' on kdb doing all sorts of fail.  Sometimes it would
> > crash, sometimes display nothing, and sometimes hang.
> >
> > Bisect tracked this down to the commit ad67b74d2469 ("printk: hash
> > addresses printed with %p"), suggesting an obvious fix.  The pointer
> > used internally in kdb shouldn't be hashed, so switch it to %px.
> >
> > Fixes: ad67b74d2469 ("printk: hash addresses printed with %p")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> I think we've already got a fix for this:
> https://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git/commit/?h=kgdb-next&id=a0ca72c2d1ac83d0853a23ffde8f3624648b1ee8

Ah ha.  Nice!  Sorry for not noticing this.  The newest I tested was 4.19.

-Doug

      reply	other threads:[~2018-10-31 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 20:53 Douglas Anderson
2018-10-31 11:59 ` Daniel Thompson
2018-10-31 15:05   ` Doug Anderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=W+NScZ8KCcBhULwmx3VMx0uUro=jKm7og9-OsRKmNdmA@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=daniel.thompson@linaro.org \
    --cc=jason.wessel@windriver.com \
    --cc=joe@perches.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@tobin.cc \
    --cc=stable@vger.kernel.org \
    --subject='Re: [PATCH] kdb: Fix btc (backtrace on each cpu) crash' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).