LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Rob Clark <robdclark@gmail.com>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Rob Clark <robdclark@chromium.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 2/3] arm64: dts: qcom: sdm845-cheza: Re-add reserved memory
Date: Mon, 13 May 2019 15:48:22 -0700 [thread overview]
Message-ID: <CAD=FV=WXW3aApS=c7baxhtfr1Nf-UnBN2s=rEBBkjj4=TCdT+g@mail.gmail.com> (raw)
In-Reply-To: <20190509184415.11592-3-robdclark@gmail.com>
Hi,
On Thu, May 9, 2019 at 11:44 AM Rob Clark <robdclark@gmail.com> wrote:
> From: Douglas Anderson <dianders@chromium.org>
>
> Let's fixup the reserved memory to re-add the things we deleted in
> ("CHROMIUM: arm64: dts: qcom: sdm845-cheza: Temporarily delete
> reserved-mem changes") in a way that plays nicely with the new
> upstream definitions.
The message above makes no sense since that commit you reference isn't
in upstream.
...but in any case, why not squash this in with the previous commit?
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Remove Stephen's Reviewed-by. In general reviews that happen in the
Chrome OS gerrit shouldn't be carried over when things are posted
upstream.
> +/* Increase the size from 2MB to 8MB */
> +&rmtfs_mem {
> + reg = <0 0x88f00000 0 0x800000>;
> +};
> +
> +/ {
> + reserved-memory {
> + venus_mem: memory@96000000 {
> + reg = <0 0x96000000 0 0x500000>;
> + no-map;
> + };
> + };
> +};
nit: blank line?
-Doug
next prev parent reply other threads:[~2019-05-13 22:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190509184415.11592-1-robdclark@gmail.com>
2019-05-09 18:44 ` [RFC 1/3] arm64: dts: qcom: sdm845-cheza: add initial cheza dt Rob Clark
2019-05-13 22:47 ` Doug Anderson
2019-05-09 18:44 ` [RFC 2/3] arm64: dts: qcom: sdm845-cheza: Re-add reserved memory Rob Clark
2019-05-13 22:48 ` Doug Anderson [this message]
2019-05-15 4:09 ` Rob Clark
2019-05-15 19:24 ` Jordan Crouse
2019-05-15 21:50 ` Doug Anderson
2019-05-15 23:41 ` Bjorn Andersson
2019-05-09 18:44 ` [RFC 3/3] arm64: dts: qcom: sdm845-cheza: delete zap-shader Rob Clark
2019-05-15 21:43 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WXW3aApS=c7baxhtfr1Nf-UnBN2s=rEBBkjj4=TCdT+g@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).