LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC
@ 2021-08-16 16:50 Shaik Sajida Bhanu
  2021-08-17 13:58 ` Doug Anderson
  2021-09-23 20:30 ` (subset) " Bjorn Andersson
  0 siblings, 2 replies; 5+ messages in thread
From: Shaik Sajida Bhanu @ 2021-08-16 16:50 UTC (permalink / raw)
  To: adrian.hunter, ulf.hansson, robh+dt
  Cc: asutoshd, stummala, pragalla, nitirawa, rampraka, sayalil,
	sartgarg, cang, linux-mmc, linux-kernel, linux-arm-msm,
	devicetree, agross, bjorn.andersson, Shaik Sajida Bhanu

The current drive strength values are not sufficient on non discrete
boards and this leads to CRC errors during switching to HS400 enhanced
strobe mode.

Hardware simulation results on non discrete boards shows up that use the
maximum drive strength values for data and command lines could helps
in avoiding these CRC errors.

So, update data and command line drive strength values to maximum.

Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 0f2b3c0..79d7aa6 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -1524,13 +1524,13 @@ ap_spi_fp: &spi10 {
 		pinconf-cmd {
 			pins = "sdc1_cmd";
 			bias-pull-up;
-			drive-strength = <10>;
+			drive-strength = <16>;
 		};
 
 		pinconf-data {
 			pins = "sdc1_data";
 			bias-pull-up;
-			drive-strength = <10>;
+			drive-strength = <16>;
 		};
 
 		pinconf-rclk {
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC
  2021-08-16 16:50 [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC Shaik Sajida Bhanu
@ 2021-08-17 13:58 ` Doug Anderson
  2021-08-19 13:44   ` Doug Anderson
  2021-09-23 20:30 ` (subset) " Bjorn Andersson
  1 sibling, 1 reply; 5+ messages in thread
From: Doug Anderson @ 2021-08-17 13:58 UTC (permalink / raw)
  To: Shaik Sajida Bhanu
  Cc: Adrian Hunter, Ulf Hansson, Rob Herring, Asutosh Das,
	Sahitya Tummala, pragalla, nitirawa, Ram Prakash Gupta,
	Sayali Lokhande, sartgarg, cang, Linux MMC List, LKML,
	linux-arm-msm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Andy Gross, Bjorn Andersson, Stephen Boyd, Matthias Kaehlcke

Hi,

On Mon, Aug 16, 2021 at 9:51 AM Shaik Sajida Bhanu
<sbhanu@codeaurora.org> wrote:
>
> The current drive strength values are not sufficient on non discrete
> boards and this leads to CRC errors during switching to HS400 enhanced
> strobe mode.
>
> Hardware simulation results on non discrete boards shows up that use the
> maximum drive strength values for data and command lines could helps
> in avoiding these CRC errors.
>
> So, update data and command line drive strength values to maximum.
>
> Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I found this CL because you created a bug for it (thanks!), but it
would have also been nice if you had CCed some folks from Google that
work on the trogdor project on your patch.


> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 0f2b3c0..79d7aa6 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -1524,13 +1524,13 @@ ap_spi_fp: &spi10 {
>                 pinconf-cmd {
>                         pins = "sdc1_cmd";
>                         bias-pull-up;
> -                       drive-strength = <10>;
> +                       drive-strength = <16>;
>                 };
>
>                 pinconf-data {
>                         pins = "sdc1_data";
>                         bias-pull-up;
> -                       drive-strength = <10>;
> +                       drive-strength = <16>;

I could be convinced that this is the right thing to do, but I want to
really make sure that it has had sufficient testing. Specifically as
this patch is written we'll be updating the drive strength for all
boards. Increasing the drive strength can sometimes introduce new
problems (reflections, noise, ...) so we have to be confident that
we're not breaking someone that used to work by increasing the drive
strength here. How much has this been tested?

From the discussions in the bugs, it seemed like the increased drive
strength was only needed for one eMMC part and that eMMC part still
had problems even after the increased drive strength, it just had
fewer problems. It would be good to confirm that I got my data
straight, but if it's right I'd be inclined _not_ to increase the
drive strength and simply to make sure we don't use that eMMC part (or
solve the problems with it in a different way). I seem to remember
that there were other eMMC-related values that could be set. Any
chance the problems are really there? Like `fixed-emmc-driver-type`?

-Doug

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC
  2021-08-17 13:58 ` Doug Anderson
@ 2021-08-19 13:44   ` Doug Anderson
  2021-09-23 20:19     ` Doug Anderson
  0 siblings, 1 reply; 5+ messages in thread
From: Doug Anderson @ 2021-08-19 13:44 UTC (permalink / raw)
  To: Shaik Sajida Bhanu
  Cc: Adrian Hunter, Ulf Hansson, Rob Herring, Asutosh Das,
	Sahitya Tummala, pragalla, nitirawa, Ram Prakash Gupta,
	Sayali Lokhande, sartgarg, cang, Linux MMC List, LKML,
	linux-arm-msm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Andy Gross, Bjorn Andersson, Stephen Boyd, Matthias Kaehlcke

Hi,

On Tue, Aug 17, 2021 at 6:58 AM Doug Anderson <dianders@google.com> wrote:
>
> >                 pinconf-data {
> >                         pins = "sdc1_data";
> >                         bias-pull-up;
> > -                       drive-strength = <10>;
> > +                       drive-strength = <16>;
>
> I could be convinced that this is the right thing to do, but I want to
> really make sure that it has had sufficient testing. Specifically as
> this patch is written we'll be updating the drive strength for all
> boards. Increasing the drive strength can sometimes introduce new
> problems (reflections, noise, ...) so we have to be confident that
> we're not breaking someone that used to work by increasing the drive
> strength here. How much has this been tested?

From further discussion internally, it sounds as if this should be
fine and fixes more than just this one eMMC part. Thus:

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC
  2021-08-19 13:44   ` Doug Anderson
@ 2021-09-23 20:19     ` Doug Anderson
  0 siblings, 0 replies; 5+ messages in thread
From: Doug Anderson @ 2021-09-23 20:19 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Adrian Hunter, Ulf Hansson, Rob Herring, Asutosh Das,
	Sahitya Tummala, pragalla, nitirawa, Ram Prakash Gupta,
	Sayali Lokhande, sartgarg, cang, Linux MMC List, LKML,
	linux-arm-msm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Andy Gross, Shaik Sajida Bhanu, Stephen Boyd, Matthias Kaehlcke

Bjorn,

On Thu, Aug 19, 2021 at 6:44 AM Doug Anderson <dianders@google.com> wrote:
>
> Hi,
>
> On Tue, Aug 17, 2021 at 6:58 AM Doug Anderson <dianders@google.com> wrote:
> >
> > >                 pinconf-data {
> > >                         pins = "sdc1_data";
> > >                         bias-pull-up;
> > > -                       drive-strength = <10>;
> > > +                       drive-strength = <16>;
> >
> > I could be convinced that this is the right thing to do, but I want to
> > really make sure that it has had sufficient testing. Specifically as
> > this patch is written we'll be updating the drive strength for all
> > boards. Increasing the drive strength can sometimes introduce new
> > problems (reflections, noise, ...) so we have to be confident that
> > we're not breaking someone that used to work by increasing the drive
> > strength here. How much has this been tested?
>
> From further discussion internally, it sounds as if this should be
> fine and fixes more than just this one eMMC part. Thus:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

We've been running with this patch in the Chrome OS kernel. If it
looks OK to you, it'd be great for it to land in your tree. Thanks!

-Doug

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: (subset) [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC
  2021-08-16 16:50 [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC Shaik Sajida Bhanu
  2021-08-17 13:58 ` Doug Anderson
@ 2021-09-23 20:30 ` Bjorn Andersson
  1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2021-09-23 20:30 UTC (permalink / raw)
  To: Shaik Sajida Bhanu, ulf.hansson, adrian.hunter, robh+dt
  Cc: rampraka, sartgarg, nitirawa, sayalil, cang, linux-mmc, agross,
	devicetree, stummala, pragalla, linux-kernel, linux-arm-msm,
	asutoshd

On Mon, 16 Aug 2021 22:20:50 +0530, Shaik Sajida Bhanu wrote:
> The current drive strength values are not sufficient on non discrete
> boards and this leads to CRC errors during switching to HS400 enhanced
> strobe mode.
> 
> Hardware simulation results on non discrete boards shows up that use the
> maximum drive strength values for data and command lines could helps
> in avoiding these CRC errors.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC
      commit: 752432e40e8f0d02d0af07cce2d6d4b250be11ef

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-09-23 20:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 16:50 [PATCH V1] arm64: dts: qcom: sc7180: Use maximum drive strength values for eMMC Shaik Sajida Bhanu
2021-08-17 13:58 ` Doug Anderson
2021-08-19 13:44   ` Doug Anderson
2021-09-23 20:19     ` Doug Anderson
2021-09-23 20:30 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).