From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F9BEC4320A for ; Wed, 11 Aug 2021 22:28:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 772E760FD9 for ; Wed, 11 Aug 2021 22:28:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232605AbhHKW2k (ORCPT ); Wed, 11 Aug 2021 18:28:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232538AbhHKW2j (ORCPT ); Wed, 11 Aug 2021 18:28:39 -0400 Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14EF1C0613D3 for ; Wed, 11 Aug 2021 15:28:15 -0700 (PDT) Received: by mail-il1-x131.google.com with SMTP id k3so4626446ilu.2 for ; Wed, 11 Aug 2021 15:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HyKdeL30nXjjFb5Hs6FMYvBRYqvi5QvkjAnHbuiglD0=; b=QCwujtXDpFac1+c3HFwq4Ii1fAtlXHlagEYEoW7I3r3AVCOYscSfxuKibuQ3gtUekL d42WQZkTSRB4Q1FUNYD0SwqdRbApQIHBpZQ3s6yl8LYLU6AZNQDEVTW8lBAyd/LZyDSR DhpfTycnoYVenCWQ1CW6HzUFzPmP+7NyGB95c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HyKdeL30nXjjFb5Hs6FMYvBRYqvi5QvkjAnHbuiglD0=; b=QBRmPkVduVbpImBQXgCstwYnFX57BQ3oNrvY+WDNKEXtp15lJrD9jFtn80OPsj2MK1 Dz7o3niSIcXyVRrpawk443csCLHbzO545Rj56vYiohudeksJsTas6vTqgRKpSeg+qKe7 4oD6HaGOLwC7Jszl+xhnS9ZkTa/iBMH7Wh+kh+JbFbLZzvra4T3riW+i6YKviXbqwpdY SEGU+3NZRVOI4ZDLd245tpXggGkBN+IwsR6QoT8yIH5KYcn5JUqLY7xvo9a5fMb+ZtjT p3XLR59KzVCvvwqvw8P0cDd9ZERhVQ9gRf+Zby2vx0yhEWtLq7QejXoqaAQzxDkzRiNl qdHw== X-Gm-Message-State: AOAM531C3k4wZmxzPnG+fVjVger1AZ7c7DiWMcWseTaIUckrR52pwGOm DznwrFKMsQkMSG850U2Rdw7gRJXgtWMoLza8 X-Google-Smtp-Source: ABdhPJwVqbVWxxLOV//iXo/ZXrNv80Dyv50tcvvHUC13PAvWIB4CSTfR4EHpLnktedkt+xTMmjauHw== X-Received: by 2002:a92:5407:: with SMTP id i7mr550928ilb.264.1628720894349; Wed, 11 Aug 2021 15:28:14 -0700 (PDT) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com. [209.85.166.54]) by smtp.gmail.com with ESMTPSA id m26sm334273ioo.23.2021.08.11.15.28.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Aug 2021 15:28:13 -0700 (PDT) Received: by mail-io1-f54.google.com with SMTP id r72so5704503iod.6 for ; Wed, 11 Aug 2021 15:28:13 -0700 (PDT) X-Received: by 2002:a05:6602:2159:: with SMTP id y25mr603783ioy.61.1628720893305; Wed, 11 Aug 2021 15:28:13 -0700 (PDT) MIME-Version: 1.0 References: <20210811194719.856593-1-swboyd@chromium.org> In-Reply-To: <20210811194719.856593-1-swboyd@chromium.org> From: Doug Anderson Date: Wed, 11 Aug 2021 15:28:02 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Fix lpass dai link for HDMI To: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , LKML , linux-arm-msm , V Sujith Kumar Reddy , Srinivasa Rao Mandadapu , Srinivas Kandagatla Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Aug 11, 2021 at 12:47 PM Stephen Boyd wrote: > > This should be the dai for display port. Without this set properly we > fail to get audio routed through external displays on trogdor. It looks > like we picked up v4[1] of this patch when there was a v7[2]. The v7 > patch still had the wrong sound-dai but at least we can fix all this up > and audio works. > > Cc: V Sujith Kumar Reddy > Cc: Srinivasa Rao Mandadapu > Cc: Srinivas Kandagatla > Fixes: b22d313e1772 ("arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI") > Link: https://lore.kernel.org/r/20210721080549.28822-3-srivasam@qti.qualcomm.com [1] > Link: https://lore.kernel.org/r/20210726120910.20335-3-srivasam@codeaurora.org [2] > Signed-off-by: Stephen Boyd > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) There were other changes between v4 and v7. Do we want to take those too? Basically two things discussed in my response to v5 [1]. 1. I think we don't need `#sound-dai-cells = <0>;` 2. It seemed marginally better to call the node `hdmi@5`, not `hdmi-primary@5`. Also, in case you're comparing to v7, it looks like v7 still had a bug, though, that your patch fixes. It still had "sound-dai = <&lpass_cpu 2>;" So confusing! [1] https://lore.kernel.org/linux-arm-msm/CAD=FV=W3X8W90vPdrDAymzTKj-J7QPyn4ukaLSOhEkCme3+r_Q@mail.gmail.com/ -Doug