LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Zhu Yanjun <zyjzyj2000@gmail.com>
To: Junji Wei <weijunji@bytedance.com>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	RDMA mailing list <linux-rdma@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	xieyongji@bytedance.com
Subject: Re: [PATCH] RDMA/rxe: Fix wrong port_cap_flags
Date: Mon, 6 Sep 2021 16:59:30 +0800	[thread overview]
Message-ID: <CAD=hENdGj2EkazVRRj3H-bO0psCAEVvTF-iEhaRTXS_KNf2Bkg@mail.gmail.com> (raw)
In-Reply-To: <DB1899F3-88A0-44A2-8F44-A380D625A98F@bytedance.com>

On Mon, Sep 6, 2021 at 3:53 PM Junji Wei <weijunji@bytedance.com> wrote:
>
>
> > On Sep 6, 2021, at 3:21 PM, Zhu Yanjun <zyjzyj2000@gmail.com> wrote:
> >
> > On Tue, Aug 31, 2021 at 4:32 PM Junji Wei <weijunji@bytedance.com> wrote:
> >>
> >> The port->attr.port_cap_flags should be set to enum
> >> ib_port_capability_mask_bits in ib_mad.h,
> >> not RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP.
> >>
> >> Signed-off-by: Junji Wei <weijunji@bytedance.com>
> >> ---
> >> drivers/infiniband/sw/rxe/rxe_param.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/infiniband/sw/rxe/rxe_param.h b/drivers/infiniband/sw/rxe/rxe_param.h
> >> index 742e6ec93686..b5a70cbe94aa 100644
> >> --- a/drivers/infiniband/sw/rxe/rxe_param.h
> >> +++ b/drivers/infiniband/sw/rxe/rxe_param.h
> >> @@ -113,7 +113,7 @@ enum rxe_device_param {
> >> /* default/initial rxe port parameters */
> >> enum rxe_port_param {
> >>        RXE_PORT_GID_TBL_LEN            = 1024,
> >> -       RXE_PORT_PORT_CAP_FLAGS         = RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP,
> >> +       RXE_PORT_PORT_CAP_FLAGS         = IB_PORT_CM_SUP,
> >
> > RXE_PORT_PORT_CAP_FLAGS         = IB_PORT_CM_SUP |
> > RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP,
> >
> > Is it better?
> >
> > Zhu Yanjun
>
> I don’t think so.
>
> Because RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP(0x800000)
> means IB_PORT_BOOT_MGMT_SUP(1 << 23) in ib_mad.h.
> RDMA_CORE_CAP_PROT_ROCE_UDP_ENCAP should be used for
> port’s core_cap_flags.

Sure. Thanks

Zhu Yanjun

>
> >
> >>        RXE_PORT_MAX_MSG_SZ             = 0x800000,
> >>        RXE_PORT_BAD_PKEY_CNTR          = 0,
> >>        RXE_PORT_QKEY_VIOL_CNTR         = 0,
> >> --
> >> 2.30.1 (Apple Git-130)
> >>
>

  reply	other threads:[~2021-09-06  8:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  8:32 Junji Wei
2021-08-31 11:54 ` Leon Romanovsky
2021-09-06  7:21 ` Zhu Yanjun
2021-09-06  7:53   ` Junji Wei
2021-09-06  8:59     ` Zhu Yanjun [this message]
2021-09-14 19:03 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=hENdGj2EkazVRRj3H-bO0psCAEVvTF-iEhaRTXS_KNf2Bkg@mail.gmail.com' \
    --to=zyjzyj2000@gmail.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=weijunji@bytedance.com \
    --cc=xieyongji@bytedance.com \
    --subject='Re: [PATCH] RDMA/rxe: Fix wrong port_cap_flags' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).