LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Li Yang <leoyang.li@nxp.com>
To: Raag Jadav <raagjadav@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ls1046a: fix eeprom entries
Date: Mon, 2 Aug 2021 17:44:29 -0500	[thread overview]
Message-ID: <CADRPPNQ2M1N1pV2brfFRXOf1ASK2bhiZpQivNhNws_+RUfCT-g@mail.gmail.com> (raw)
In-Reply-To: <1627927742-8675-1-git-send-email-raagjadav@gmail.com>

On Mon, Aug 2, 2021 at 1:10 PM Raag Jadav <raagjadav@gmail.com> wrote:
>
> ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2]
> eeproms respectively. Both are 4Kb (512 bytes) in size.

These part names are from onsemi instead of atmel.  Are there same
part names from atmel which are also compatible with the onsemi parts?
 If we want to use onsemi only part names, probably we will need two
compatible strings with the first one from onsemi and the second from
atmel.  Although the binding doesn't support onsemi prefix yet.

> Remove multi-address entries, as we have auto-rollover support
> in at24 driver.

The device tree should describe hardware instead of matching how
driver deal with it.  Is the board really using a single chip or
multiple chips here?

>
> [1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf
> [2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf
>
> Signed-off-by: Raag Jadav <raagjadav@gmail.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts | 8 +-------
>  arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts  | 7 +------
>  2 files changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> index db3d303..83afe21 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> @@ -83,15 +83,9 @@
>                         };
>
>                         eeprom@52 {
> -                               compatible = "atmel,24c512";
> +                               compatible = "atmel,24c04";
>                                 reg = <0x52>;
>                         };
> -
> -                       eeprom@53 {
> -                               compatible = "atmel,24c512";
> -                               reg = <0x53>;
> -                       };
> -
>                 };
>         };
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> index 60acdf0..d220f98 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> @@ -59,14 +59,9 @@
>         };
>
>         eeprom@52 {
> -               compatible = "atmel,24c512";
> +               compatible = "atmel,24c04";
>                 reg = <0x52>;
>         };
> -
> -       eeprom@53 {
> -               compatible = "atmel,24c512";
> -               reg = <0x53>;
> -       };
>  };
>
>  &i2c3 {
> --
> 2.7.4
>

  reply	other threads:[~2021-08-02 22:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 18:09 Raag Jadav
2021-08-02 22:44 ` Li Yang [this message]
2021-08-03 19:44   ` Raag Jadav
2021-08-03 22:20     ` Li Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADRPPNQ2M1N1pV2brfFRXOf1ASK2bhiZpQivNhNws_+RUfCT-g@mail.gmail.com \
    --to=leoyang.li@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raagjadav@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --subject='Re: [PATCH] arm64: dts: ls1046a: fix eeprom entries' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).