LKML Archive on
help / color / mirror / Atom feed
From: Sudip Mukherjee <>
To: Greg Kroah-Hartman <>
Cc: kernel-janitors <>,
	linux-kernel <>,
	Colin King <>
Subject: Re: [PATCH] parport: remove non-zero check on count
Date: Thu, 19 Aug 2021 21:52:07 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Jul 30, 2021 at 11:07 AM Colin King <> wrote:
> From: Colin Ian King <>
> The check for count appears to be incorrect since a non-zero count
> check occurs a couple of statements earlier. Currently the check is
> always false and the dev->port->irq != PARPORT_IRQ_NONE part of the
> check is never tested and the if statement is dead-code. Fix this
> by removing the check on count.
> Note that this code is pre-git history, so I can't find a sha for
> it.
> Addresses-Coverity: ("Logically dead code")
> Signed-off-by: Colin Ian King <>

Acked-by: Sudip Mukherjee <>

Greg, can you please take it through your tree..
I think you might not have it in your queue as you were not in the
original recipient list, if so, I can send it after adding my Ack to


  reply	other threads:[~2021-08-19 20:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 10:07 [PATCH] parport: remove non-zero check on count Colin King
2021-08-19 20:52 ` Sudip Mukherjee [this message]
2021-08-27 14:18   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).