LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCHv2 1/1] arm64: To remove initrd reserved area entry from memblock
       [not found] <CGME20180430041448epcas1p228a727858328da77c67c01c25802b86d@epcas1p2.samsung.com>
@ 2018-04-30  4:13 ` CHANDAN VN
  2018-04-30  4:28   ` Chandan Vn
  0 siblings, 1 reply; 4+ messages in thread
From: CHANDAN VN @ 2018-04-30  4:13 UTC (permalink / raw)
  To: catalin.marinas, will.deacon, takahiro.akashi, james.morse,
	robin.murphy, labbott, steve.capper, kristina.martsenko,
	linux-arm-kernel, linux-kernel
  Cc: cpgs, chandan.vn, vn.chandan

INITRD reserved area entry is not removed from memblock
even though initrd reserved area is freed. After freeing
the memory it is released from memblock. The same can be
checked from /sys/kernel/debug/memblock/reserved.

The patch makes sure that the initrd entry is removed from
memblock when keepinitrd is not enabled.

The patch only affects accounting and debugging. This does not
fix any memory leak.

Signed-off-by: CHANDAN VN <chandan.vn@samsung.com>
---
 arch/arm64/mm/init.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
index 9f3c47a..1b18b47 100644
--- a/arch/arm64/mm/init.c
+++ b/arch/arm64/mm/init.c
@@ -646,8 +646,10 @@ void free_initmem(void)
 
 void __init free_initrd_mem(unsigned long start, unsigned long end)
 {
-	if (!keep_initrd)
+	if (!keep_initrd) {
 		free_reserved_area((void *)start, (void *)end, 0, "initrd");
+		memblock_free(__virt_to_phys(start), end - start);
+	}
 }
 
 static int __init keepinitrd_setup(char *__unused)
-- 
1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHv2 1/1] arm64: To remove initrd reserved area entry from memblock
  2018-04-30  4:13 ` [PATCHv2 1/1] arm64: To remove initrd reserved area entry from memblock CHANDAN VN
@ 2018-04-30  4:28   ` Chandan Vn
  0 siblings, 0 replies; 4+ messages in thread
From: Chandan Vn @ 2018-04-30  4:28 UTC (permalink / raw)
  To: CHANDAN VN
  Cc: catalin.marinas, will.deacon, Takahiro Akashi, james.morse,
	robin.murphy, Laura Abbott, steve.capper, kristina.martsenko,
	linux-arm-kernel, linux-kernel, cpgs

Please ignore this mail. I missed replying to the thread.
I have resubmitted over the proper thread.

On Mon, 30 Apr 2018, 09:44 CHANDAN VN, <chandan.vn@samsung.com> wrote:
>
> INITRD reserved area entry is not removed from memblock
> even though initrd reserved area is freed. After freeing
> the memory it is released from memblock. The same can be
> checked from /sys/kernel/debug/memblock/reserved.
>
> The patch makes sure that the initrd entry is removed from
> memblock when keepinitrd is not enabled.
>
> The patch only affects accounting and debugging. This does not
> fix any memory leak.
>
> Signed-off-by: CHANDAN VN <chandan.vn@samsung.com>
> ---
>  arch/arm64/mm/init.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 9f3c47a..1b18b47 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -646,8 +646,10 @@ void free_initmem(void)
>
>  void __init free_initrd_mem(unsigned long start, unsigned long end)
>  {
> -       if (!keep_initrd)
> +       if (!keep_initrd) {
>                 free_reserved_area((void *)start, (void *)end, 0, "initrd");
> +               memblock_free(__virt_to_phys(start), end - start);
> +       }
>  }
>
>  static int __init keepinitrd_setup(char *__unused)
> --
> 1.9.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHv2 1/1] arm64: To remove initrd reserved area entry from memblock
  2018-04-30  4:20   ` [PATCHv2 " CHANDAN VN
@ 2018-04-30 17:21     ` Laura Abbott
  0 siblings, 0 replies; 4+ messages in thread
From: Laura Abbott @ 2018-04-30 17:21 UTC (permalink / raw)
  To: CHANDAN VN, catalin.marinas, will.deacon, takahiro.akashi,
	james.morse, robin.murphy, steve.capper, kristina.martsenko,
	linux-arm-kernel, linux-kernel
  Cc: cpgs, vn.chandan

On 04/29/2018 09:20 PM, CHANDAN VN wrote:
> INITRD reserved area entry is not removed from memblock
> even though initrd reserved area is freed. After freeing
> the memory it is released from memblock. The same can be
> checked from /sys/kernel/debug/memblock/reserved.
> 
> The patch makes sure that the initrd entry is removed from
> memblock when keepinitrd is not enabled.
> 
> The patch only affects accounting and debugging. This does not
> fix any memory leak.
> 
> Signed-off-by: CHANDAN VN <chandan.vn@samsung.com>
> ---
>   arch/arm64/mm/init.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 9f3c47a..1b18b47 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -646,8 +646,10 @@ void free_initmem(void)
>   
>   void __init free_initrd_mem(unsigned long start, unsigned long end)
>   {
> -	if (!keep_initrd)
> +	if (!keep_initrd) {
>   		free_reserved_area((void *)start, (void *)end, 0, "initrd");
> +		memblock_free(__virt_to_phys(start), end - start);
> +	}
>   }
>   
>   static int __init keepinitrd_setup(char *__unused)
> 

Acked-by: Laura Abbott <labbott@redhat.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCHv2 1/1] arm64: To remove initrd reserved area entry from memblock
       [not found] ` <CGME20180430042028epcas2p24418c10ebe7b2c656cdfc31e98ed540b@epcas2p2.samsung.com>
@ 2018-04-30  4:20   ` CHANDAN VN
  2018-04-30 17:21     ` Laura Abbott
  0 siblings, 1 reply; 4+ messages in thread
From: CHANDAN VN @ 2018-04-30  4:20 UTC (permalink / raw)
  To: catalin.marinas, will.deacon, takahiro.akashi, james.morse,
	robin.murphy, labbott, steve.capper, kristina.martsenko,
	linux-arm-kernel, linux-kernel
  Cc: cpgs, chandan.vn, vn.chandan

INITRD reserved area entry is not removed from memblock
even though initrd reserved area is freed. After freeing
the memory it is released from memblock. The same can be
checked from /sys/kernel/debug/memblock/reserved.

The patch makes sure that the initrd entry is removed from
memblock when keepinitrd is not enabled.

The patch only affects accounting and debugging. This does not
fix any memory leak.

Signed-off-by: CHANDAN VN <chandan.vn@samsung.com>
---
 arch/arm64/mm/init.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
index 9f3c47a..1b18b47 100644
--- a/arch/arm64/mm/init.c
+++ b/arch/arm64/mm/init.c
@@ -646,8 +646,10 @@ void free_initmem(void)
 
 void __init free_initrd_mem(unsigned long start, unsigned long end)
 {
-	if (!keep_initrd)
+	if (!keep_initrd) {
 		free_reserved_area((void *)start, (void *)end, 0, "initrd");
+		memblock_free(__virt_to_phys(start), end - start);
+	}
 }
 
 static int __init keepinitrd_setup(char *__unused)
-- 
1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-04-30 17:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20180430041448epcas1p228a727858328da77c67c01c25802b86d@epcas1p2.samsung.com>
2018-04-30  4:13 ` [PATCHv2 1/1] arm64: To remove initrd reserved area entry from memblock CHANDAN VN
2018-04-30  4:28   ` Chandan Vn
2018-04-06  4:53 [PATCH " CHANDAN VN
     [not found] ` <CGME20180430042028epcas2p24418c10ebe7b2c656cdfc31e98ed540b@epcas2p2.samsung.com>
2018-04-30  4:20   ` [PATCHv2 " CHANDAN VN
2018-04-30 17:21     ` Laura Abbott

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).