From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D95C4338F for ; Mon, 16 Aug 2021 18:54:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE91060F36 for ; Mon, 16 Aug 2021 18:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231150AbhHPSyi (ORCPT ); Mon, 16 Aug 2021 14:54:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230143AbhHPSyh (ORCPT ); Mon, 16 Aug 2021 14:54:37 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F593C061764 for ; Mon, 16 Aug 2021 11:54:05 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id t128so28161653oig.1 for ; Mon, 16 Aug 2021 11:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YoY9bHgtBFBdh+LL5q9r5ScpCfKdiLG+MRqaif3YEI8=; b=naoSBJkgtcuj5qgJOEZkSZimaplLVdgNyuZkSUQOT4oTguOAkX6UV9uhieY+czuvyC yKl+WA0CV9mqasUFr9PIYgiR087D0pB2DSlo7BJlIJOIeH8jZe90iieO/YLidSIvyGcF y120bsGWC2BVTQ4HihQP1T9IDivfmdAump1sI1BksIJxwB5U864hAmI+CYPqoUxVmf9b rtYUU/gjJHllsB4yhuL/fsFmr4fSG2UYhzvG3SxadqL7yAr1+lzHaT65vfY+b4nAv6pE riWxWjM/lMBOuoaoLzdmW2IFQuhDZ6aS10JodX0K8HOixim9MKDvwfe3gqNhyZrNomrY F2nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YoY9bHgtBFBdh+LL5q9r5ScpCfKdiLG+MRqaif3YEI8=; b=OieHEt56K0g1me98t7TZ9wi9oWpUfWouU4f17O1IiCfjjP39X8Kw6N4kOWws1kls/K +3pdiulJiQslOuNQnWIQxVCLZi5zESRA3+2SCsdIdn67Z71mUrF73v//js2LAQ0HpGs3 UOHlOq80O/1j+2WJq1iLNik29xwWWTflNgSB5FaTLihItD6B24VkcYvCVoGEERdiBN40 gaz93ODKLwJgOOMtnoIG1KHhU91HyK+RiAJs00lnqIebWrzY/i3ma9kDvvfF4Qdh9phN CzKXE0UH0TfEBFUOQXBgBDytoL5q5/EouN/qDbr91tqhsLeLuPW+RnwAkFqeWf0ItpSP MihA== X-Gm-Message-State: AOAM5310UYFOWSCB0VMF0Hukb6bvO+qbFUwho/3piZc3xw6x96c591mo M3BKAP0HrcOJjSgD9OW9RGwFGV1+vWgaePT20ho= X-Google-Smtp-Source: ABdhPJyjsT23z+JKUtzE0jLgdLWJv7SfrxzzaZKXzkFJJLzPFGv15wqNC71FHrLBwBKGtq3duPeYyc8o86vTH0Psaxc= X-Received: by 2002:a05:6808:1390:: with SMTP id c16mr128831oiw.123.1629140045025; Mon, 16 Aug 2021 11:54:05 -0700 (PDT) MIME-Version: 1.0 References: <20210815192959.90142-1-nathan@kernel.org> In-Reply-To: From: Alex Deucher Date: Mon, 16 Aug 2021 14:53:53 -0400 Message-ID: Subject: Re: [PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object() To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Nathan Chancellor , Alex Deucher , "Pan, Xinhui" , Nick Desaulniers , "Gustavo A. R. Silva" , Kees Cook , amd-gfx list , Maling list - DRI developers , LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Mon, Aug 16, 2021 at 3:23 AM Christian K=C3=B6nig wrote: > > Am 15.08.21 um 21:29 schrieb Nathan Chancellor: > > Clang + -Wimplicit-fallthrough warns: > > > > drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated > > fall-through between switch labels [-Wimplicit-fallthrough] > > default: > > ^ > > drivers/gpu/drm/radeon/radeon_fb.c:170:2: note: insert 'break;' to avoi= d > > fall-through > > default: > > ^ > > break; > > 1 warning generated. > > > > Clang's version of this warning is a little bit more pedantic than > > GCC's. Add the missing break to satisfy it to match what has been done > > all over the kernel tree. > > > > Signed-off-by: Nathan Chancellor > > Reviewed-by: Christian K=C3=B6nig > > > --- > > drivers/gpu/drm/radeon/radeon_fb.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeo= n/radeon_fb.c > > index 0b206b052972..c8b545181497 100644 > > --- a/drivers/gpu/drm/radeon/radeon_fb.c > > +++ b/drivers/gpu/drm/radeon/radeon_fb.c > > @@ -167,6 +167,7 @@ static int radeonfb_create_pinned_object(struct rad= eon_fbdev *rfbdev, > > break; > > case 2: > > tiling_flags |=3D RADEON_TILING_SWAP_16BIT; > > + break; > > default: > > break; > > } > > > > base-commit: ba31f97d43be41ca99ab72a6131d7c226306865f >