LKML Archive on
help / color / mirror / Atom feed
From: Alex Deucher <>
To: Bjorn Helgaas <>
Cc: Alex Williamson <>,
	Linux PCI <>,
	Dave Airlie <>,
	"Deucher, Alexander" <>,
	Maling list - DRI developers  <>,
	LKML <>
Subject: Re: [PATCH 0/2] PCI: pci_unignore_hotplug()
Date: Fri, 6 Mar 2015 17:12:34 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Mar 6, 2015 at 1:49 PM, Bjorn Helgaas <> wrote:
> On Tue, Feb 24, 2015 at 03:23:27PM -0500, Alex Deucher wrote:
>> On Tue, Feb 24, 2015 at 3:12 PM, Alex Williamson
>> <> wrote:
>> > I'd kinda like to use pci_ignore_hotplug() for devices in use by a
>> > user via vfio-pci, but the interface seems only partially implemented
>> > since we can only set ignore_hotplug and not clear it.  This adds the
>> > capability to clear the flag and applies it as seems to be appropriate
>> > to the existing users.  I don't have a system with power control for
>> > a radeon or nouveau device, so I'd certainly appreciate testing.  It
>> > seems though that once the device is in D0, we've passed the critical
>> > point where the device could be accidentally unplugged.  Thanks,
>> Something re-broke this recently.  See:
> I'm not opposed to adding pci_unignore_hotplug() when we have users for it.
> I don't really want to throw in the nouveau and radeon changes while there
> are open issues in the same area, though.
> I haven't looked at the bugzillas above.  Let me know if I should.

Please do.  My comments were not targeted at this patch set, but
rather at the fact that pci hotplug (acpiphp in this case) is again
trying to remove the driver even though it's flagged to ignore hotplug
in the hybrid laptop case.


      reply	other threads:[~2015-03-06 22:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 20:12 Alex Williamson
2015-02-24 20:12 ` [PATCH 1/2] pci: Add reciprocal function for pci_ignore_hotplug() Alex Williamson
2015-02-24 20:12 ` [PATCH 2/2] nouveau/radeon: Un-ignore hotplug on resume Alex Williamson
2015-02-24 20:23 ` [PATCH 0/2] PCI: pci_unignore_hotplug() Alex Deucher
2015-03-06 18:49   ` Bjorn Helgaas
2015-03-06 22:12     ` Alex Deucher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 0/2] PCI: pci_unignore_hotplug()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).