LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Dikshita Agarwal <dikshita@codeaurora.org>,
	linux-media@vger.kernel.org, stanimir.varbanov@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	vgarodia@codeaurora.org
Subject: Re: [PATCH v4 5/7] venus: vdec: set work route to fw
Date: Thu, 12 Aug 2021 12:20:05 -0700	[thread overview]
Message-ID: <CAE-0n50y1PHu--5dg3ehYcmyLGsU6V7-VnPfVLoN452dK04TVA@mail.gmail.com> (raw)
In-Reply-To: <1628588875-23790-6-git-send-email-dikshita@codeaurora.org>

Quoting Dikshita Agarwal (2021-08-10 02:47:53)
> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
> index 198e47e..4e7b9e5 100644
> --- a/drivers/media/platform/qcom/venus/vdec.c
> +++ b/drivers/media/platform/qcom/venus/vdec.c
> @@ -653,6 +653,24 @@ static int vdec_set_properties(struct venus_inst *inst)
>         return 0;
>  }
>
> +static int vdec_set_work_route(struct venus_inst *inst)
> +{
> +       struct hfi_video_work_route wr;
> +       u32 ptype;
> +       int ret;
> +
> +       if(!IS_V6(inst->core))

Please add a space after 'if'

> +               return 0;
> +
> +       wr.video_work_route = inst->core->res->num_vpp_pipes;
> +
> +       ptype = HFI_PROPERTY_PARAM_WORK_ROUTE;
> +       ret = hfi_session_set_property(inst, ptype, &wr);
> +       if (ret)
> +               return ret;
> +       return 0;

return hfi_session_set_property(...) is shorter.

> +}
> +
>  #define is_ubwc_fmt(fmt) (!!((fmt) & HFI_COLOR_FORMAT_UBWC_BASE))
>
>  static int vdec_output_conf(struct venus_inst *inst)

  reply	other threads:[~2021-08-12 19:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  9:47 [PATCH v4 0/7] media: venus: Enable venus support on sc7280 Dikshita Agarwal
2021-08-10  9:47 ` [PATCH v4 1/7] venus: firmware: enable no tz fw loading for sc7280 Dikshita Agarwal
2021-08-10  9:47 ` [PATCH v4 2/7] media: venus: core: Add sc7280 DT compatible and resource data Dikshita Agarwal
2021-08-12 19:17   ` Stephen Boyd
2021-08-10  9:47 ` [PATCH v4 3/7] media: venus: Add num_vpp_pipes to resource structure Dikshita Agarwal
2021-08-10  9:47 ` [PATCH v4 4/7] media: venus: hfi: Skip AON register programming for V6 1pipe Dikshita Agarwal
2021-08-10  9:47 ` [PATCH v4 5/7] venus: vdec: set work route to fw Dikshita Agarwal
2021-08-12 19:20   ` Stephen Boyd [this message]
2021-08-10  9:47 ` [PATCH v4 6/7] media: venus: helpers: update NUM_MBS macro calculation Dikshita Agarwal
2021-10-01 21:31   ` Stanimir Varbanov
2021-10-04  7:37     ` dikshita
2021-08-10  9:47 ` [PATCH v4 7/7] media: venus: Set buffer to FW based on FW min count requirement Dikshita Agarwal
2021-08-30  7:28 ` [PATCH v4 0/7] media: venus: Enable venus support on sc7280 dikshita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE-0n50y1PHu--5dg3ehYcmyLGsU6V7-VnPfVLoN452dK04TVA@mail.gmail.com \
    --to=swboyd@chromium.org \
    --cc=dikshita@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=stanimir.varbanov@linaro.org \
    --cc=vgarodia@codeaurora.org \
    --subject='Re: [PATCH v4 5/7] venus: vdec: set work route to fw' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).