LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: bjorn.andersson@linaro.org, mka@chromium.org, robh+dt@kernel.org,
ulf.hansson@linaro.org, rjw@rjwysocki.net, agross@kernel.org,
ohad@wizery.com, mathieu.poirier@linaro.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, rishabhb@codeaurora.org,
sidgup@codeaurora.org
Subject: Re: [PATCH v5 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP property
Date: Sat, 21 Aug 2021 11:17:34 -0700 [thread overview]
Message-ID: <CAE-0n50z=MaEZhXRSQpN6Jo8m7nyQSS6MqikAgT5cfkH1ZvL_g@mail.gmail.com> (raw)
In-Reply-To: <d733d47bc6a86fe28302943e50d02bd5@codeaurora.org>
Quoting Sibi Sankar (2021-08-20 07:24:02)
> On 2021-08-20 00:25, Stephen Boyd wrote:
> > Quoting Sibi Sankar (2021-08-18 20:02:05)
> >> The load state power-domain, used by the co-processors to notify the
> >> Always on Subsystem (AOSS) that a particular co-processor is up/down,
> >> suffers from the side-effect of changing states during suspend/resume.
> >> However the co-processors enter low-power modes independent to that of
> >> the application processor and their states are expected to remain
> >> unaltered across system suspend/resume cycles. To achieve this
> >> behavior
> >> let's drop the load state power-domain and replace them with the qmp
> >> property for all SoCs supporting low power mode signalling.
> >>
> >
> > How do we drop the load state property without breaking existing DTBs?
> > Maybe we need to leave it there and then somehow make it optional? Or
> > do
> > we not care about this problem as the driver will start ignoring it?
>
> We can afford to break the bindings
> because of the following reason:
>
> * Load state in mainline is currently
> broken i.e. it doesn't serve its
> main purpose of signalling AOP of
> the correct state of Q6 during
> system suspend/resume. Thus we
> can maintain current functionality
> even without the load state votes
> i.e. when a new kernel with load
> state removed is used with an older
> dtb the remoteproc functionality
> will remain the same.
>
Alright. Is that reflected somewhere in the commit text? I must have
missed it. Can you please add it?
next prev parent reply other threads:[~2021-08-21 18:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 3:02 [PATCH v5 00/13] Use qmp_send to update co-processor load state Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 01/13] dt-bindings: soc: qcom: aoss: Drop the load state power-domain Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP property Sibi Sankar
2021-08-19 18:55 ` Stephen Boyd
2021-08-20 14:24 ` Sibi Sankar
2021-08-21 18:17 ` Stephen Boyd [this message]
2021-08-23 16:19 ` Sibi Sankar
2021-08-23 20:18 ` Stephen Boyd
2021-08-19 3:02 ` [PATCH v5 03/13] dt-bindings: remoteproc: qcom: " Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 04/13] remoteproc: qcom: q6v5: Use qmp_send to update co-processor load state Sibi Sankar
2021-08-23 20:17 ` Stephen Boyd
2021-08-19 3:02 ` [PATCH v5 05/13] arm64: dts: qcom: sc7180: Use QMP property to control " Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 06/13] arm64: dts: qcom: sc7280: " Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 07/13] arm64: dts: qcom: sdm845: " Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 08/13] arm64: dts: qcom: sm8150: " Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 09/13] arm64: dts: qcom: sm8250: " Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 10/13] arm64: dts: qcom: sm8350: " Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 11/13] soc: qcom: aoss: Drop power domain support Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 12/13] dt-bindings: msm/dp: Remove aoss-qmp header Sibi Sankar
2021-08-19 3:02 ` [PATCH v5 13/13] dt-bindings: soc: qcom: aoss: Delete unused power-domain definitions Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n50z=MaEZhXRSQpN6Jo8m7nyQSS6MqikAgT5cfkH1ZvL_g@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=rishabhb@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--subject='Re: [PATCH v5 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP property' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).