From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB1D2C4338F for ; Mon, 23 Aug 2021 23:50:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A774761378 for ; Mon, 23 Aug 2021 23:50:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233375AbhHWXvX (ORCPT ); Mon, 23 Aug 2021 19:51:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233327AbhHWXut (ORCPT ); Mon, 23 Aug 2021 19:50:49 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED511C061575 for ; Mon, 23 Aug 2021 16:50:05 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id o16-20020a9d2210000000b0051b1e56c98fso26259781ota.8 for ; Mon, 23 Aug 2021 16:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=WoDDjdzbvPyEs19Npp+KsDh7LDnbNT5MIojU8+tk5Fw=; b=lxV+LoLa6AmzEui46cKIIlmIVceP1kYM8VWwX7911dwfuaalkODC+0x8OScWBEMuc+ R5+iNiCXJR/9dZKmqhyjGONtNUjng1Uh4paCMbcZbPTX1zbc9gwrOZeeQJ6c9R9p97ut 8sh+04l2eksB3ZaemEeRRbtxSvyMcIGshrD+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=WoDDjdzbvPyEs19Npp+KsDh7LDnbNT5MIojU8+tk5Fw=; b=mRKQa2SrYI6rhtaU9qEs+ibZ+Gh96s+RH/a5okbtq4gjhZwZsRrcMsNjcud4AVp4v+ XiCZKdqqBoTwCe9fBr+++cDjsINY5JdSrl6kYtHAezQRxGFp9AF9tOcIUNFNv2TwoZfo FuswDu64ipm76YivmayiOObgZmU+LLxeJ72Hoy7bPFJnlwVFDhQeDf0P4knndXZjScd2 ec6HsjNj0VUmeA6lyxLvQ9uviW63oD2pTrLkXYfV3We3JZHghnllz6RmRLsWM0vgKAxa Cr2GaiAz/GUKjaKwfYYVQDiyVolYCKNqPQFWDfhhkpx04btmE0uXJA6PK36GFhjr8rPy 1jXw== X-Gm-Message-State: AOAM532pk8WSdhis30OlUlf1tg2/53VXweuJKPdYR/bX8PwblGNtVa1+ Co1acttUxRTmbeRYePBDptCzVdX1bp5dUhzSonDRZA== X-Google-Smtp-Source: ABdhPJyplZFiLcT/PUaK7ZB+YTOaFz++lRFqFYou4I57i80IsaoaIZAZ18qqb81QRva1zUDu1wKPZC4CXzo1GJhyYpY= X-Received: by 2002:a05:6830:2473:: with SMTP id x51mr22956792otr.34.1629762605326; Mon, 23 Aug 2021 16:50:05 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 23 Aug 2021 18:50:04 -0500 MIME-Version: 1.0 In-Reply-To: <20210823134726.1.I1dd23ddf77e5b3568625d80d6827653af071ce19@changeid> References: <20210823134726.1.I1dd23ddf77e5b3568625d80d6827653af071ce19@changeid> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 23 Aug 2021 18:50:04 -0500 Message-ID: Subject: Re: [PATCH] thermal: qcom: spmi-adc-tm5: Don't abort probing if a sensor is not used To: Amit Kucheria , Andy Gross , Bjorn Andersson , Daniel Lezcano , Dmitry Baryshkov , Matthias Kaehlcke , Thara Gopinath , Zhang Rui Cc: linux-pm@vger.kernel.org, Douglas Anderson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Matthias Kaehlcke (2021-08-23 13:47:30) > adc_tm5_register_tzd() registers the thermal zone sensors for all > channels of the thermal monitor. If the registration of one channel > fails the function skips the processing of the remaining channels > and returns an error, which results in _probe() being aborted. > > One of the reasons the registration could fail is that none of the > thermal zones is using the channel/sensor, which hardly is a critical > error (if it is an error at all). If this case is detected emit a > warning and continue with processing the remaining channels. > > Fixes: ca66dca5eda6 ("thermal: qcom: add support for adc-tm5 PMIC thermal monitor") > Signed-off-by: Matthias Kaehlcke > --- Reported-by: Stephen Boyd Reviewed-by: Stephen Boyd Should we also disable the 'charger-thermistor@0' node in sc7180-trogdor.dtsi on lazor boards, instead of the thermal zone, or in addition to the thermal zone? It isn't used so there's not much value in exposing it.