From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3837C43214 for ; Mon, 16 Aug 2021 21:08:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C561A60EE5 for ; Mon, 16 Aug 2021 21:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233207AbhHPVIp (ORCPT ); Mon, 16 Aug 2021 17:08:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232812AbhHPVIo (ORCPT ); Mon, 16 Aug 2021 17:08:44 -0400 Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 749F0C0613CF for ; Mon, 16 Aug 2021 14:08:12 -0700 (PDT) Received: by mail-oo1-xc30.google.com with SMTP id h7-20020a4ab4470000b0290263c143bcb2so5325281ooo.7 for ; Mon, 16 Aug 2021 14:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=DhhEi9REryF7Euqq+T5kr4qdAnwWtXdUixXZ+suk4Bc=; b=ZFFABO/zVDWWQmLLx0RAO6ybYuaWOdMI8nfvqWkZjHWT8a6efPqOopO3FP63sz7FCF euRekIkxlsBrNPkbbInMLWEp5RUGKhseciWZxhfOUiN7ek051Qryieqvixa9QRfxErmP fGQRczUdjxKv75kS7gpw4JjRovjWd6GJIh454= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=DhhEi9REryF7Euqq+T5kr4qdAnwWtXdUixXZ+suk4Bc=; b=YzjJ2I6UqeS0HLfQMApNi1Lg97HmCvsrR3q1kEzBvb1F2g0/UGscVrEVc1CGJ0Nk7e /LS2VswUvYXkkj6zZE2gQeVJKlOVu6OW4i+kgYMClCng+/C2rkvkbS3H2UULegrebtMr jkXpU7FWszLDVCxY3mp8G3etR5BJDjY2TJ1YHlY0AKKP9JCvwJee0XsAeBuoSFK/V3dE g61CEO7Ou91vXT2wxk+Fm6WT6cQf2unK2fYiRB2LtsmcA79iJTb/mR/gCbW/DKKcsXyr iwAcQUCn4maqPWxZNoikbNfYNNgGa01VklcGG309cYox5jyn3RmfOveI43t0Nji9iw6M d4nQ== X-Gm-Message-State: AOAM531k32qRGQDTxpV1VewVD5BiJW4Wp7X3w507bWZfCkR2GAj/9gcr sYHSKmmAJJgW8U1cApVxVbaZ3FwnlrHLTN1Zq6OMLw== X-Google-Smtp-Source: ABdhPJwkW0aWkQ3eA/CgUBtD3vfjlQxS+WPjQ68YkWRc3r79J/uwSbmFY0qfQ58wr1VReoLjN/jo6yEDlFehMe1Pnb0= X-Received: by 2002:a4a:3651:: with SMTP id p17mr191016ooe.92.1629148091816; Mon, 16 Aug 2021 14:08:11 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 16 Aug 2021 14:08:11 -0700 MIME-Version: 1.0 In-Reply-To: <4af8171aefd6f0387438225666ec1ccc@codeaurora.org> References: <1628830531-14648-1-git-send-email-skakit@codeaurora.org> <1628830531-14648-2-git-send-email-skakit@codeaurora.org> <4af8171aefd6f0387438225666ec1ccc@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 16 Aug 2021 14:08:11 -0700 Message-ID: Subject: Re: [PATCH 1/2] pinctrl: qcom: spmi-gpio: correct parent irqspec translation To: Linus Walleij , skakit@codeaurora.org Cc: Rob Herring , Andy Gross , Bjorn Andersson , David Collins , Kiran Gunda , linux-gpio@vger.kernel.org, linux-kernel , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting skakit@codeaurora.org (2021-08-15 23:50:37) > Hi Linus, > > On 2021-08-13 14:27, Linus Walleij wrote: > > Hi Satya/David, > > > > nice work on identifying this bug! > > > > On Fri, Aug 13, 2021 at 6:56 AM satya priya > > wrote: > >> > >> From: David Collins > >> > >> pmic_gpio_child_to_parent_hwirq() and > >> gpiochip_populate_parent_fwspec_fourcell() translate a pinctrl- > >> spmi-gpio irqspec to an SPMI controller irqspec. When they do > >> this, they use a fixed SPMI slave ID of 0 and a fixed GPIO > >> peripheral offset of 0xC0 (corresponding to SPMI address 0xC000). > >> This translation results in an incorrect irqspec for secondary > >> PMICs that don't have a slave ID of 0 as well as for PMIC chips > >> which have GPIO peripherals located at a base address other than > >> 0xC000. > >> > >> Correct this issue by passing the slave ID of the pinctrl-spmi- > >> gpio device's parent in the SPMI controller irqspec and by > >> calculating the peripheral ID base from the device tree 'reg' > >> property of the pinctrl-spmi-gpio device. > >> > >> Signed-off-by: David Collins > >> Signed-off-by: satya priya Can you please add an appropriate Fixes tag? > > > > Is this a regression or is it fine if I just apply it for v5.15? > > I was thinking v5.15 since it isn't yet used in device trees. > > > > Without this fix, [2/2] Vol+ support is failing. If possible please > merge it on current branch. > Are there any boards supported upstream that have a gpio block that isn't at 0xc000?