LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Evan Green <evgreen@chromium.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Naveen M <naveen.m@intel.com>,
	Sathya Prakash <sathya.prakash.m.r@intel.com>,
	Ben Zhang <benzh@chromium.org>, Rajat Jain <rajatja@chromium.org>,
	Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, LKML <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs
Date: Wed, 8 May 2019 09:42:45 -0700	[thread overview]
Message-ID: <CAE=gft7PtNWzH1QYigbQvDcJwZSb7ZLWoKzurPGBnh72DYcZrw@mail.gmail.com> (raw)
In-Reply-To: <cb0accd5-6b0d-065a-9b54-321252862d88@linux.intel.com>

On Tue, May 7, 2019 at 3:14 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
> Minor nit-picks below. The Kconfig would work but select CANNONLAKE even
> if you don't want it.
>
> >
> > +config SND_SOC_SOF_COMETLAKE_LP
> > +     tristate
> > +     select SND_SOC_SOF_CANNONLAKE
>
> This should be
> select SND_SOF_SOF_HDA_COMMON

You mean SND_SOC_SOF_HDA_COMMON I assume.
Except that I also need &cnl_desc, so I need CANNONLAKE to be on as
well. Should I select them both?
-Evan

  reply	other threads:[~2019-05-08 16:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 21:53 [PATCH v2 0/2] ASoC: Intel: Add Cometlake " Evan Green
2019-05-07 21:53 ` [PATCH v2 1/2] ASoC: SOF: Add Comet Lake " Evan Green
2019-05-07 22:14   ` Pierre-Louis Bossart
2019-05-08 16:42     ` Evan Green [this message]
2019-05-08 17:00       ` Pierre-Louis Bossart
2019-05-08 21:58         ` Evan Green
2019-05-07 21:53 ` [PATCH v2 2/2] ASoC: Intel: Skylake: Add Cometlake " Evan Green
2019-05-07 22:31   ` Pierre-Louis Bossart
2019-05-08 16:51     ` Evan Green
2019-05-08 17:04       ` Pierre-Louis Bossart
2019-05-08 21:57         ` Evan Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE=gft7PtNWzH1QYigbQvDcJwZSb7ZLWoKzurPGBnh72DYcZrw@mail.gmail.com' \
    --to=evgreen@chromium.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=benzh@chromium.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveen.m@intel.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rajatja@chromium.org \
    --cc=sathya.prakash.m.r@intel.com \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).