LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Evan Green <evgreen@chromium.org>
To: Manu Gautam <mgautam@codeaurora.org>
Cc: kishon@ti.com, linux-arm-msm@vger.kernel.org,
vivek.gautam@codeaurora.org, varada@codeaurora.org,
weiyongjun1@huawei.com, fengguang.wu@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] phy: qcom-qmp: Add QMP V3 USB3 UNI PHY support for sdm845
Date: Tue, 20 Mar 2018 16:36:51 +0000 [thread overview]
Message-ID: <CAE=gft7gsj8yKMw2mX7Tw_0pH8vwr-UmtqjyUXnHXr8YFBi_Og@mail.gmail.com> (raw)
In-Reply-To: <5db561b9-0c39-14d3-f924-9e5db75f6600@codeaurora.org>
On Tue, Mar 20, 2018 at 12:00 AM Manu Gautam <mgautam@codeaurora.org> wrote:
> Hi,
> On 3/19/2018 11:21 PM, Evan Green wrote:
> > Hi Manu,
> >
> > On Fri, Mar 16, 2018 at 2:46 AM Manu Gautam <mgautam@codeaurora.org>
wrote:
> [snip]
> >> index d1c6905..5d78d43 100644
> >> --- a/drivers/phy/qualcomm/phy-qcom-qmp.h
> >> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.h
> >> @@ -214,6 +214,8 @@
> >> #define QSERDES_V3_RX_UCDR_FASTLOCK_FO_GAIN 0x030
> >> #define QSERDES_V3_RX_UCDR_SO_SATURATION_AND_ENABLE 0x034
> >> #define QSERDES_V3_RX_RX_TERM_BW 0x07c
> >> +#define QSERDES_V3_RX_VGA_CAL_CNTRL1 0x0bc
> > I noticed you add this definition, but never use it. Are you missing a
> > QMP_PHY_INIT_CFG line for this register in qmp_v3_usb3_uniphy_rx_tbl[],
or
> > is that register "don't care"? It looks important, and while its default
> > value out of reset might be valid, you never know what nutty value boot
> > firmware might set it to.
> >
> Yes POR value of this register is valid for this soc.
> QMP driver resets (asserts and de-asserts reset_control) in probe. So,
that should
> ensure that PHY registers are indeed set to POR value. Left the
definition there
> if different setting needed to be done for a different variant of h/w in
future.
Sounds good. Thanks, Manu.
Reviewed-by: Evan Green <evgreen@chromium.org>
next prev parent reply other threads:[~2018-03-20 16:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1521193500-4696-1-git-send-email-mgautam@codeaurora.org>
2018-03-16 9:44 ` [PATCH 1/6] phy: qcom-qmp: Enable pipe_clk before checking USB3 PHY_STATUS Manu Gautam
2018-03-16 9:44 ` [PATCH 2/6] phy: qcom-qusb2: Fix crash if nvmem cell not specified Manu Gautam
2018-03-20 10:12 ` Vivek Gautam
2018-03-16 9:44 ` [PATCH 3/6] dt-bindings: phy-qcom-qmp: Update bindings for sdm845 Manu Gautam
2018-03-18 12:52 ` Rob Herring
2018-03-16 9:44 ` [PATCH 4/6] phy: qcom-qmp: Add QMP V3 USB3 UNI PHY support " Manu Gautam
2018-03-19 17:51 ` Evan Green
2018-03-20 6:59 ` Manu Gautam
2018-03-20 16:36 ` Evan Green [this message]
2018-03-16 9:44 ` [PATCH 5/6] dt-bindings: phy-qcom-usb2: Update bindings " Manu Gautam
2018-03-18 12:52 ` Rob Herring
2018-03-19 4:41 ` Manu Gautam
2018-03-20 10:23 ` Vivek Gautam
2018-03-20 10:42 ` Manu Gautam
2018-03-16 9:44 ` [PATCH 6/6] phy: qcom-qusb2: Add QUSB2 PHYs support " Manu Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft7gsj8yKMw2mX7Tw_0pH8vwr-UmtqjyUXnHXr8YFBi_Og@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=fengguang.wu@intel.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=varada@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).