LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel Baluta <daniel.baluta@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Kevin Tsai <ktsai@capellamicro.com>,
	Daniel Baluta <daniel.baluta@intel.com>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: light: Add support for Capella CM3323 color/light sensor
Date: Mon, 9 Mar 2015 22:38:45 +0200	[thread overview]
Message-ID: <CAEnQRZCAAmcs3M+2NkNknDV_2kqHEgKbsECkLpspCYJu1vQ-7Q@mail.gmail.com> (raw)
In-Reply-To: <54FDC005.2000905@kernel.org>

On Mon, Mar 9, 2015 at 5:45 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 02/03/15 19:03, Kevin Tsai wrote:
>> Hi Daniel,
>>
>> Ambient light sensor is trying to match the brightness sensitivity of human visual system.  Please see the following links:
>> http://en.wikipedia.org/wiki/Color_vision#mediaviewer/File:Eyesensitivity.svg
>> http://en.wikipedia.org/wiki/Color_vision
>>
>> You can compare the spectrum with the datasheet.  The green channel is matched with ALS spectrum.
> It's close (ish) to the right measurement, but it isn't the right measurement.  As such
> I'd argue we leave it up to userspace to make the jump and use Green if a true estimate
> if illuminance isn't available, but don't suggest it is available from the kernel.


Ok, I will respin the patch with this in mind.

thanks,
Daniel.

      reply	other threads:[~2015-03-09 20:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 10:10 Daniel Baluta
2015-01-22 10:48 ` Peter Meerwald
2015-01-25 10:27 ` Jonathan Cameron
2015-01-25 10:50   ` Daniel Baluta
2015-03-02  9:57     ` Daniel Baluta
2015-03-02 19:03       ` Kevin Tsai
2015-03-09 15:45         ` Jonathan Cameron
2015-03-09 20:38           ` Daniel Baluta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEnQRZCAAmcs3M+2NkNknDV_2kqHEgKbsECkLpspCYJu1vQ-7Q@mail.gmail.com \
    --to=daniel.baluta@intel.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=ktsai@capellamicro.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --subject='Re: [PATCH] iio: light: Add support for Capella CM3323 color/light sensor' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).