LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel Baluta <daniel.baluta@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"S.j. Wang" <shengjiu.wang@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524
Date: Mon, 20 May 2019 13:12:22 +0300	[thread overview]
Message-ID: <CAEnQRZDazHW173hzERz+RiOAsiRQNVNOQihz8Lz=+Bp5cZzgpQ@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5A6Gv5k3up0AtKrhQPyMLMe_8SXift68KEP2J+j8D_cJg@mail.gmail.com>

<reduce audience to linux-imx>

Shengjiu,

Can you help me with this? Specifically: I couldn't find the schematic
showing the
exact connection pins between SAI and wm8524 codec.

I looked into our internal tree and the wm8524 codec always handles
CLK_SAIX_ROOT
but Fabio has a good point. This clock doesn't feeds the codec.

Unless, we can really look into the schematics and prove it otherwise.

On Thu, May 16, 2019 at 10:14 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Wed, May 15, 2019 at 11:42 AM Daniel Baluta <daniel.baluta@nxp.com> wrote:
>
> > +               simple-audio-card,codec {
> > +                       sound-dai = <&wm8524>;
> > +                       clocks = <&clk IMX8MM_CLK_SAI3_ROOT>;
>
> IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3
> interface, not an external clock that feeds the codec.
>
> It seems you should remove this 'clocks' entry.

  reply	other threads:[~2019-05-20 10:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 14:42 [RESEND PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK Daniel Baluta
2019-05-15 14:42 ` [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes Daniel Baluta
2019-05-16 18:33   ` Fabio Estevam
2019-05-20 19:33     ` Fabio Estevam
2019-05-31  7:27   ` Shawn Guo
2019-05-15 14:42 ` [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Daniel Baluta
2019-05-16 18:35   ` Fabio Estevam
2019-05-20 10:12     ` Daniel Baluta [this message]
2019-05-20 19:34       ` Fabio Estevam
2019-05-20 19:32     ` Fabio Estevam
2019-05-28  7:10       ` Daniel Baluta
2019-05-31  7:28         ` Shawn Guo
2019-05-31  7:42           ` Shawn Guo
  -- strict thread matches above, loose matches on Subject: below --
2019-04-24 15:04 [PATCH v3 0/2] Enable wm8524 codec on i.MX8MM EVK Daniel Baluta
2019-04-24 15:04 ` [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524 Daniel Baluta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEnQRZDazHW173hzERz+RiOAsiRQNVNOQihz8Lz=+Bp5cZzgpQ@mail.gmail.com' \
    --to=daniel.baluta@gmail.com \
    --cc=aisheng.dong@nxp.com \
    --cc=daniel.baluta@nxp.com \
    --cc=festevam@gmail.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shengjiu.wang@nxp.com \
    --subject='Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).