LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Rob Clark <firstname.lastname@example.org> To: Doug Anderson <email@example.com> Cc: Laurent Pinchart <firstname.lastname@example.org>, dri-devel <email@example.com>, linux-arm-msm <firstname.lastname@example.org>, freedreno <email@example.com>, Stephen Boyd <firstname.lastname@example.org>, Rob Clark <email@example.com>, Andrzej Hajda <firstname.lastname@example.org>, Neil Armstrong <email@example.com>, Robert Foss <firstname.lastname@example.org>, Jonas Karlman <email@example.com>, Jernej Skrabec <firstname.lastname@example.org>, David Airlie <email@example.com>, Daniel Vetter <firstname.lastname@example.org>, open list <email@example.com> Subject: Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support Date: Mon, 20 Sep 2021 11:32:02 -0700 [thread overview] Message-ID: <CAF6AEGt8K=iy8=dn+GJxt7ybfPtGDPy9w3StqWDwyOv_CKLNVg@mail.gmail.com> (raw) In-Reply-To: <CAD=FV=Xd9fizYdxfXYOkpJ_1fZcHp3-ROJ7k4iPg0g0RQ_+A3Q@mail.gmail.com> On Thu, Aug 12, 2021 at 1:08 PM Doug Anderson <firstname.lastname@example.org> wrote: > > Laurent, > > On Thu, Aug 12, 2021 at 12:26 PM Laurent Pinchart > <email@example.com> wrote: > > > > Hi Rob, > > > > Thank you for the patch. > > > > On Wed, Aug 11, 2021 at 04:52:50PM -0700, Rob Clark wrote: > > > From: Rob Clark <firstname.lastname@example.org> > > > > > > Slightly awkward to fish out the display_info when we aren't creating > > > own connector. But I don't see an obvious better way. > > > > We need a bit more than this, to support the NO_CONNECTOR case, the > > bridge has to implement a few extra operations, and set the bridge .ops > > field. I've submitted two patches to do so a while ago: > > > > - [RFC PATCH 08/11] drm/bridge: ti-sn65dsi86: Implement bridge connector operations () > > Rob asked me about this over IRC, so if he left it out and it's needed > then it's my fault. However, I don't believe it's needed until your > series making this bridge chip support full DP. For the the eDP case > the bridge chip driver in ToT no longer queries the EDID itself. It > simply provides an AUX bus to the panel driver and the panel driver > queries the EDID. I think that means we don't need to add > DRM_BRIDGE_OP_EDID, right? > > I was also wondering if in the full DP case we should actually model > the physical DP jack as a drm_bridge and have it work the same way. It > would get probed via the DP AUX bus just like a panel. I seem to > remember Stephen Boyd was talking about modeling the DP connector as a > drm_bridge because it would allow us to handle the fact that some TCPC > chips could only support HBR2 whereas others could support HBR3. Maybe > it would end up being a fairly elegant solution? > > > - [RFC PATCH 09/11] drm/bridge: ti-sn65dsi86: Make connector creation optional () > > > > The second patch is similar to the first half of this patch, but misses > > the cleanup code. I'll try to rebase this and resubmit, but it may take > > a bit of time. > > Whoops! You're right that Rob's patch won't work at all because we'll > just hit the "Fix bridge driver to make connector optional!" case. I > should have noticed that. :( Yes, indeed.. once I fix that, I get no display.. Not sure if Laurent is still working on his series, otherwise I can try to figure out what bridge ops are missing BR, -R
next prev parent reply other threads:[~2021-09-21 2:18 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-11 23:52 [PATCH 0/4] drm/msm+ti-sn65dsi86: Fix NO_CONNECTOR fallout Rob Clark 2021-08-11 23:52 ` [PATCH 1/4] drm/bridge: ti-sn65dsi86: Avoid creating multiple connectors Rob Clark 2021-08-12 0:25 ` Stephen Boyd 2021-08-12 16:38 ` Laurent Pinchart 2021-08-12 16:54 ` Doug Anderson 2021-08-12 17:11 ` Rob Clark 2021-08-11 23:52 ` [PATCH 2/4] drm/msm/dsi: Support NO_CONNECTOR bridges Rob Clark 2021-08-12 16:44 ` Laurent Pinchart [not found] ` <YRVa6Wy/24FUQEUw@ravnborg.org> 2021-08-12 17:45 ` Rob Clark 2021-08-11 23:52 ` [PATCH 3/4] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid() Rob Clark 2021-08-12 17:23 ` Doug Anderson 2021-08-12 18:44 ` Laurent Pinchart 2021-08-12 19:09 ` Rob Clark 2021-08-12 19:17 ` Laurent Pinchart 2021-08-11 23:52 ` [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support Rob Clark 2021-08-12 17:22 ` Doug Anderson 2021-08-12 19:26 ` Laurent Pinchart 2021-08-12 20:08 ` Doug Anderson 2021-09-20 18:32 ` Rob Clark [this message] 2021-09-23 0:39 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAF6AEGt8K=iy8=dn+GJxt7ybfPtGDPy9w3StqWDwyOv_CKLNVg@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).