From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF29C4320A for ; Sat, 28 Aug 2021 16:00:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AD686054E for ; Sat, 28 Aug 2021 16:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234486AbhH1QBe (ORCPT ); Sat, 28 Aug 2021 12:01:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230290AbhH1QBb (ORCPT ); Sat, 28 Aug 2021 12:01:31 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E993C061756; Sat, 28 Aug 2021 09:00:40 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id me10so20724045ejb.11; Sat, 28 Aug 2021 09:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q+Lu3zsplYuNKF2IF+QmpVTl2y5bBSCP+aSg8wuwsiw=; b=HF+xsgvsnrJrPToIAqza2r4D+a2I4uKoEWs4qUPB9ZtxE2lP61oybEuf71lmwwsehc chY8Av/MqB3ykfHwW0Ja5AxiiZmS4/DeXKkolm4txdYKhEzQZ5l138XMO3+VGsgrn+CR qwuu/5OM9ZpeW453SAUOh2G0AL+xSwJflEuEAGZTKZRElo1NZcF6YyQ3H8TiHqZmsX9W cIp2roGNC2b7of6WssIXw6mppEIUbFl7OvHHsaudDCz6Zt2sFliwpt/O0M5kPzE1zl1N 756MlwT00hoeEpixvex5O9YwQCeeFTh1XN4lFUY34JKFo2eSz4EfQNcOSLu2WHn5h/N7 mH3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q+Lu3zsplYuNKF2IF+QmpVTl2y5bBSCP+aSg8wuwsiw=; b=RIMVKLZlsL32dyIcp2aUGMkwdJ8hDwCsa68WNKJLKEVZTqPyMENUBcuCJStN23DL/c arKZ1ra35+J+vZLqQ91mNybPZwilMVXw8i9Yu9DyfPpYz3WotaAemZPloBtO950tYe9u yW5M2nLZujS1R6jAB/5lqINvOxx1tLQfK/foR58B83b8WVJO4JBc/rNnus65zxf7Qucd nmfmIDeafQoOa30QVGa2aI3iNz8lrc7ZSlKP+ZzsGvB+xVK+YiMORa2Uy7LwaRQbBnac SfIQ+fVIZNK4PSJwMS3KyLUuWVQ2NHC25KADXZ9ki63bAiaExbpxLbLWFYXIwdJWZldf /meg== X-Gm-Message-State: AOAM531DLl1h05KSYXUSjZ4q2T6U256dGh512SQKtKwSd6FzNpfv3Pdw vuKVI7g/fBu4idUJAz99Kje73GdthArsxiBAlyU= X-Google-Smtp-Source: ABdhPJwD2vEA5j8yQQHHv0y4xe5OPRu0rQ5pLqz4tIRsU3/TzhWBp80jORvSGA8DCjkphVreH8wjKsmX3LcpVwfxUqE= X-Received: by 2002:a17:906:369a:: with SMTP id a26mr15768976ejc.539.1630166438950; Sat, 28 Aug 2021 09:00:38 -0700 (PDT) MIME-Version: 1.0 References: <20210817041548.1276-1-linux.amoon@gmail.com> <20210817041548.1276-4-linux.amoon@gmail.com> In-Reply-To: <20210817041548.1276-4-linux.amoon@gmail.com> From: Martin Blumenstingl Date: Sat, 28 Aug 2021 18:00:28 +0200 Message-ID: Subject: Re: [PATCHv3 3/6] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power To: Anand Moon Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Matt Corallo , Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Kishon Vijay Abraham I , Vinod Koul , Emiliano Ingrassia , Brian Kim Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anand, On Tue, Aug 17, 2021 at 6:17 AM Anand Moon wrote: > > Fix the chip enable signal changing from Active High to Active Low > to enable input power to USB power. Also updated signal name as per > the schematics. according to [0] (page 12) Odroid-C2 uses an "RT9715EGB" for USB OTG power The datasheet for that power switch [1] mentions on page page 1 that the "E" stands for "E : 1.1A/Active High" Can you please elaborate how you have tested this to confirm that active low is the correct polarity? Best regards, Martin [0] https://dn.odroid.com/S905/Schematic/odroid-c2_rev0.1_20150930.pdf [1] https://www.richtek.com/assets/product_file/RT9715/DS9715-03.pdf