LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
@ 2018-04-11  4:42 ianwmorrison
  2018-04-11  9:24 ` Jani Nikula
  0 siblings, 1 reply; 18+ messages in thread
From: ianwmorrison @ 2018-04-11  4:42 UTC (permalink / raw)
  To: rodrigo.vivi, anusha.srivatsa, michal.wajdeczko, gregkh, airlied,
	jani.nikula, joonas.lahtinen
  Cc: linux-kernel, stable, intel-gfx, dri-devel, ianwmorrison

From: Ian W MORRISON <ianwmorrison@gmail.com>

As the Geminilake firmware is now merged to linux-firmware.git
use MODUE_FIRMWARE to load the firmware.

This removes the error message in the dmesg log: 

    i915 0000:00:02.0: Direct firmware load for 
        i915/glk_dmc_ver1_04.bin failed with error -2
    i915 0000:00:02.0: Failed to load DMC firmware 
        i915/glk_dmc_ver1_04.bin. Disabling runtime power management.
    i915 0000:00:02.0: DMC firmware homepage:
        https://01.org/linuxgraphics/downloads/firmware

and now shows that the firmware has correctly loaded:

    [drm] Finished loading DMC firmware i915/glk_dmc_ver1_04.bin (v1.4)

Cc: stable@vger.kernel.org
Signed-off-by: Ian W MORRISON <ianwmorrison@gmail.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 41e6c75a7f3c..f9550ea46c26 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -35,6 +35,7 @@
  */
 
 #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
+MODULE_FIRMWARE(I915_CSR_GLK);
 #define GLK_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
 #define I915_CSR_CNL "i915/cnl_dmc_ver1_07.bin"
-- 
2.11.0

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2018-04-30  7:58 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-11  4:42 [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake ianwmorrison
2018-04-11  9:24 ` Jani Nikula
2018-04-11 10:41   ` Ian W MORRISON
2018-04-11 12:27     ` Jani Nikula
2018-04-11 13:04       ` Ian W MORRISON
2018-04-16 22:47       ` Srivatsa, Anusha
2018-04-17  9:02         ` Jani Nikula
2018-04-17 14:14           ` Joonas Lahtinen
2018-04-20  5:47             ` Ian W MORRISON
2018-04-20  7:50               ` Jani Nikula
2018-04-20  8:25                 ` Ian W MORRISON
2018-04-20 18:03           ` Rodrigo Vivi
2018-04-20 18:30             ` Srivatsa, Anusha
2018-04-21  1:22               ` Botello Ortega, Luis
2018-04-21 22:46                 ` Ian W MORRISON
2018-04-25 23:15                   ` Ian W MORRISON
2018-04-27  9:20                     ` Jani Nikula
2018-04-30  7:58                       ` Joonas Lahtinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).