From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8861C433FE for ; Tue, 21 Sep 2021 08:36:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1D00611C5 for ; Tue, 21 Sep 2021 08:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231255AbhIUIiV (ORCPT ); Tue, 21 Sep 2021 04:38:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230497AbhIUIiU (ORCPT ); Tue, 21 Sep 2021 04:38:20 -0400 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 489FAC061574 for ; Tue, 21 Sep 2021 01:36:52 -0700 (PDT) Received: by mail-oi1-x232.google.com with SMTP id a3so3829658oid.6 for ; Tue, 21 Sep 2021 01:36:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bg3GdEDta4alq5EcpFnKMHpnaJigutsFTYZs6RKXRos=; b=ZcFBBgvctstgt5BhYORG28cC2JeYUdHavEY11rLRXIZvTkm8Yu5uJVKhUXDjwFImiZ r/axHGTlAB+yxUTSTbKqOhuVqpsHspq+986dff4TH6985kUVPib7cXfSjIB+G7pVNBzn dMtirIg9a9z4Cg58clgML0lnqbFg9H7GuwArqrNOEowK0V+S3oN75xO8adhAugIfY4Uj 2QXgCUbmQGJ2KqCwDfSscJiIn/MWaqf7s69HTZlNS1Eq4zO10K3NSaHZzNYjQ9O4ASoF K7VirpStOPOKGScn4nNYRoG2AC6YuDVoR6wEf57DeA0h8DQsGJeKqCQdY+nBxCw55Aey IMTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bg3GdEDta4alq5EcpFnKMHpnaJigutsFTYZs6RKXRos=; b=UGmqct8cLZR8+1T7UqJiwL8wjKNP1NxzvN4I1EwIpkoJDOuSnQ7lFgUgJxSGmtFqz/ MZpnyH+7tZU6aq9MFS8quxWkbPI2zoJKbAY6SiehjGZO0JdWqUFnjCnBurmskGKwy396 3KuxFo7V/6Fs/aun74XARHJ3TAZHKL2t7UsuhJtmdhgqWiKCBMRG/3rdMDoksZCJndJX cnDK89IX1X6WAq0LHM2L9Mexs3Bto+/Y0xRTogBOulGWuJ1uaJjpflHEvVOXHbjE10pb w97Uw9fCKNN3dZgBEr9cMjkpEEMCP8a7r9jglWnTEuM0/9GLg6wU7fSFTsNsWO2sc7t/ 4/IQ== X-Gm-Message-State: AOAM53183ZdWsw0bzxQdzhxL+DuF0ENL3UOc8U/oASbmYSgONkbIJEdB d7HWAnSYUAC0pc6sU6TgHsqR/uNddbV95VLNAtw= X-Google-Smtp-Source: ABdhPJz5b/t20bc16VMoDEDAs3Czo0etpYXIUTXIwcba8wdCT/5iOp8lmpW35rcqNJGzZ/xm3fh6WNrdzNR/tqD3mxs= X-Received: by 2002:aca:210d:: with SMTP id 13mr2651010oiz.47.1632213411694; Tue, 21 Sep 2021 01:36:51 -0700 (PDT) MIME-Version: 1.0 References: <20210808234733.14782-1-chunkuang.hu@kernel.org> In-Reply-To: From: Enric Balletbo Serra Date: Tue, 21 Sep 2021 10:36:39 +0200 Message-ID: Subject: Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver To: Chun-Kuang Hu Cc: Philipp Zabel , David Airlie , Daniel Vetter , Yongqiang Niu , linux-kernel , DRI Development , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chun-Kuang, (again without html format, sorry for the noise) Missatge de Chun-Kuang Hu del dia dj., 12 d=E2=80=99ag. 2021 a les 2:13: > > Chun-Kuang Hu =E6=96=BC 2021=E5=B9=B48=E6=9C=88= 9=E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8A=E5=8D=887:47=E5=AF=AB=E9=81=93=EF= =BC=9A > > > > These refinements include using standard mailbox callback interface, > > timeout detection, and a fixed cmdq_handle. > > For this series, applied to mediatek-drm-next [1]. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.gi= t/log/?h=3Dmediatek-drm-next > These patches seem to break the display on the Acer Chromebook R 13 (MT8173) in the current mainline. After running a bisection it pointed me to the following commit commit f4be17cd5b14dd73545b0e014a63ebe9ab5ef837 Author: Chun-Kuang Hu Date: Sun Jul 4 15:36:48 2021 +0800 drm/mediatek: Remove struct cmdq_client Reverting this patch alone is not trivial, so I ended up reverting the full series, and I can confirm that reverting the full series makes the display work again. Unfortunately, after the merge window, different things broke for this device, and I didn't finish isolating them, and it is not clear to me yet whether the logs I'm getting are useful for this specific issue or not. Basically with this series merged the kernel seems to be stuck, and the display is not working. Latest message is [ 12.329173] mtk-iommu 10205000.iommu: Partial TLB flush timed out, falling back to full flush Without the series, the kernel goes far and display works, however there are other issues affecting the cros-ec, but I think that's another issue. I'll try to dig a bit more, but, meanwhile, if you have any idea please let me know. Thanks, Enric > Regards, > Chun-Kuang. > > > > > Changes in v2: > > 1. Define mtk_drm_cmdq_pkt_create() and mtk_drm_cmdq_pkt_destroy() > > when CONFIG_MTK_CMDQ is reachable. > > > > Chun-Kuang Hu (4): > > drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb > > drm/mediatek: Remove struct cmdq_client > > drm/mediatek: Detect CMDQ execution timeout > > drm/mediatek: Add cmdq_handle in mtk_crtc > > > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 110 ++++++++++++++++++++---- > > 1 file changed, 91 insertions(+), 19 deletions(-) > > > > -- > > 2.25.1 > >