LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Souptick Joarder <jrdr.linux@gmail.com>
To: airlied@linux.ie, Arnd Bergmann <arnd@arndb.de>,
	Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2] char: agp: Change return type to vm_fault_t
Date: Mon, 2 Jul 2018 21:33:19 +0530	[thread overview]
Message-ID: <CAFqt6zYKOaieNEQE3TrXLoh9uXwcWH496EyuT_Tuyf8nZ1zd=w@mail.gmail.com> (raw)
In-Reply-To: <CAFqt6zYX-BsGsTHzEzWHWTLGA=7VtSMWYy7w8dBx+hTzxyhyfw@mail.gmail.com>

On Mon, Jun 18, 2018 at 5:07 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> On Thu, May 31, 2018 at 10:38 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>> On Mon, May 21, 2018 at 11:47 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
>>> Use new return type vm_fault_t for fault handler. For now,
>>> this is just documenting that the function returns a
>>> VM_FAULT value rather than an errno. Once all instances are
>>> converted, vm_fault_t will become a distinct type.
>>>
>>> Ref-> commit 1c8f422059ae ("mm: change return type to
>>> vm_fault_t") was added in 4.17-rc1 to introduce the new
>>> typedef vm_fault_t. Currently we are making change to all
>>> drivers to return vm_fault_t for page fault handlers. As
>>> part of that char/agp driver is also getting changed to
>>> return vm_fault_t type from fault handler.
>>>
>>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>>> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
>>> ---
>>>  drivers/char/agp/alpha-agp.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/char/agp/alpha-agp.c b/drivers/char/agp/alpha-agp.c
>>> index 53fe633..c9bf2c2 100644
>>> --- a/drivers/char/agp/alpha-agp.c
>>> +++ b/drivers/char/agp/alpha-agp.c
>>> @@ -11,7 +11,7 @@
>>>
>>>  #include "agp.h"
>>>
>>> -static int alpha_core_agp_vm_fault(struct vm_fault *vmf)
>>> +static vm_fault_t alpha_core_agp_vm_fault(struct vm_fault *vmf)
>>>  {
>>>         alpha_agp_info *agp = agp_bridge->dev_private_data;
>>>         dma_addr_t dma_addr;
>>> --
>>> 1.9.1
>>>
>>
>> Any comment for this patch ?
>
> Any further comment on this patch ?

Greg, Can we get this patch in queue for 4.19 ?

  reply	other threads:[~2018-07-02 16:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 18:17 Souptick Joarder
2018-05-31  5:08 ` Souptick Joarder
2018-06-18 11:37   ` Souptick Joarder
2018-07-02 16:03     ` Souptick Joarder [this message]
2018-07-02 16:12       ` Greg KH
2018-07-02 16:48         ` Souptick Joarder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFqt6zYKOaieNEQE3TrXLoh9uXwcWH496EyuT_Tuyf8nZ1zd=w@mail.gmail.com' \
    --to=jrdr.linux@gmail.com \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH v2] char: agp: Change return type to vm_fault_t' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).