LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drm/msm/dp: Remove unused variable
@ 2021-07-09  2:48 Souptick Joarder
  2021-07-09  3:10 ` [Freedreno] " abhinavk
  2021-07-14 21:39 ` Stephen Boyd
  0 siblings, 2 replies; 4+ messages in thread
From: Souptick Joarder @ 2021-07-09  2:48 UTC (permalink / raw)
  To: robdclark, sean, airlied, daniel, khsieh, abhinavk, swboyd,
	dmitry.baryshkov, chandanu, tanmay
  Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel,
	Souptick Joarder, kernel test robot

Kernel test roobot throws below warning ->

drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
warning: variable 'drm' set but not used [-Wunused-but-set-variable]

Removed unused variable drm.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/gpu/drm/msm/dp/dp_display.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 051c1be1de7e..d42635a86d20 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -1014,10 +1014,8 @@ int dp_display_get_test_bpp(struct msm_dp *dp)
 void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp)
 {
 	struct dp_display_private *dp_display;
-	struct drm_device *drm;
 
 	dp_display = container_of(dp, struct dp_display_private, dp_display);
-	drm = dp->drm_dev;
 
 	/*
 	 * if we are reading registers we need the link clocks to be on
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Freedreno] [PATCH] drm/msm/dp: Remove unused variable
  2021-07-09  2:48 [PATCH] drm/msm/dp: Remove unused variable Souptick Joarder
@ 2021-07-09  3:10 ` abhinavk
  2021-07-14 21:39 ` Stephen Boyd
  1 sibling, 0 replies; 4+ messages in thread
From: abhinavk @ 2021-07-09  3:10 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: robdclark, sean, airlied, daniel, khsieh, swboyd,
	dmitry.baryshkov, chandanu, tanmay, kernel test robot,
	linux-arm-msm, linux-kernel, dri-devel, freedreno

On 2021-07-08 19:48, Souptick Joarder wrote:
> Kernel test roobot throws below warning ->
> 
> drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
> warning: variable 'drm' set but not used [-Wunused-but-set-variable]
> 
> Removed unused variable drm.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/dp/dp_display.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> b/drivers/gpu/drm/msm/dp/dp_display.c
> index 051c1be1de7e..d42635a86d20 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -1014,10 +1014,8 @@ int dp_display_get_test_bpp(struct msm_dp *dp)
>  void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp 
> *dp)
>  {
>  	struct dp_display_private *dp_display;
> -	struct drm_device *drm;
> 
>  	dp_display = container_of(dp, struct dp_display_private, dp_display);
> -	drm = dp->drm_dev;
> 
>  	/*
>  	 * if we are reading registers we need the link clocks to be on

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/msm/dp: Remove unused variable
  2021-07-09  2:48 [PATCH] drm/msm/dp: Remove unused variable Souptick Joarder
  2021-07-09  3:10 ` [Freedreno] " abhinavk
@ 2021-07-14 21:39 ` Stephen Boyd
  2021-08-02 14:46   ` Souptick Joarder
  1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2021-07-14 21:39 UTC (permalink / raw)
  To: Souptick Joarder, abhinavk, airlied, chandanu, daniel,
	dmitry.baryshkov, khsieh, robdclark, sean, tanmay
  Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, kernel test robot

Quoting Souptick Joarder (2021-07-08 19:48:34)
> Kernel test roobot throws below warning ->
>
> drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
> warning: variable 'drm' set but not used [-Wunused-but-set-variable]
>
> Removed unused variable drm.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/msm/dp: Remove unused variable
  2021-07-14 21:39 ` Stephen Boyd
@ 2021-08-02 14:46   ` Souptick Joarder
  0 siblings, 0 replies; 4+ messages in thread
From: Souptick Joarder @ 2021-08-02 14:46 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: abhinavk, David Airlie, chandanu, Daniel Vetter,
	dmitry.baryshkov, khsieh, Rob Clark, sean, tanmay, linux-arm-msm,
	dri-devel, freedreno, linux-kernel, kernel test robot

On Thu, Jul 15, 2021 at 3:09 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Souptick Joarder (2021-07-08 19:48:34)
> > Kernel test roobot throws below warning ->
> >
> > drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
> > warning: variable 'drm' set but not used [-Wunused-but-set-variable]
> >
> > Removed unused variable drm.
> >

Can we get this in queue for 5.15, if no further comment ?


> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-02 14:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09  2:48 [PATCH] drm/msm/dp: Remove unused variable Souptick Joarder
2021-07-09  3:10 ` [Freedreno] " abhinavk
2021-07-14 21:39 ` Stephen Boyd
2021-08-02 14:46   ` Souptick Joarder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).