LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] perf: Remove duplicate headers
@ 2019-04-06 13:36 Souptick Joarder
  2019-04-06 18:49 ` Mukesh Ojha
  0 siblings, 1 reply; 6+ messages in thread
From: Souptick Joarder @ 2019-04-06 13:36 UTC (permalink / raw)
  To: peterz, mingo, acme, alexander.shishkin, namhyung, ak, eranian
  Cc: linux-kernel, sabyasachi.linux, brajeswar.linux, Souptick Joarder

Removed duplicate headers which are included twice.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 tools/perf/util/data.c                 | 1 -
 tools/perf/util/get_current_dir_name.c | 1 -
 tools/perf/util/stat-display.c         | 1 -
 3 files changed, 3 deletions(-)

diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
index 6a64f71..509a41e 100644
--- a/tools/perf/util/data.c
+++ b/tools/perf/util/data.c
@@ -8,7 +8,6 @@
 #include <unistd.h>
 #include <string.h>
 #include <asm/bug.h>
-#include <sys/types.h>
 #include <dirent.h>
 
 #include "data.h"
diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
index 267aa60..ebb80cd 100644
--- a/tools/perf/util/get_current_dir_name.c
+++ b/tools/perf/util/get_current_dir_name.c
@@ -5,7 +5,6 @@
 #include "util.h"
 #include <unistd.h>
 #include <stdlib.h>
-#include <stdlib.h>
 
 /* Android's 'bionic' library, for one, doesn't have this */
 
diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index 6d043c7..7b3a16c 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -12,7 +12,6 @@
 #include "string2.h"
 #include "sane_ctype.h"
 #include "cgroup.h"
-#include <math.h>
 #include <api/fs/fs.h>
 
 #define CNTR_NOT_SUPPORTED	"<not supported>"
-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf: Remove duplicate headers
  2019-04-06 13:36 [PATCH] perf: Remove duplicate headers Souptick Joarder
@ 2019-04-06 18:49 ` Mukesh Ojha
  2019-04-16 11:57   ` Souptick Joarder
  0 siblings, 1 reply; 6+ messages in thread
From: Mukesh Ojha @ 2019-04-06 18:49 UTC (permalink / raw)
  To: Souptick Joarder, peterz, mingo, acme, alexander.shishkin,
	namhyung, ak, eranian
  Cc: linux-kernel, sabyasachi.linux, brajeswar.linux


On 4/6/2019 7:06 PM, Souptick Joarder wrote:
> Removed duplicate headers which are included twice.
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> ---
>   tools/perf/util/data.c                 | 1 -
>   tools/perf/util/get_current_dir_name.c | 1 -
>   tools/perf/util/stat-display.c         | 1 -
>   3 files changed, 3 deletions(-)
>
> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> index 6a64f71..509a41e 100644
> --- a/tools/perf/util/data.c
> +++ b/tools/perf/util/data.c
> @@ -8,7 +8,6 @@
>   #include <unistd.h>
>   #include <string.h>
>   #include <asm/bug.h>
> -#include <sys/types.h>
>   #include <dirent.h>
>   
>   #include "data.h"
> diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> index 267aa60..ebb80cd 100644
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -5,7 +5,6 @@
>   #include "util.h"
>   #include <unistd.h>
>   #include <stdlib.h>
> -#include <stdlib.h>
>   
>   /* Android's 'bionic' library, for one, doesn't have this */
>   
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 6d043c7..7b3a16c 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -12,7 +12,6 @@
>   #include "string2.h"
>   #include "sane_ctype.h"
>   #include "cgroup.h"
> -#include <math.h>
>   #include <api/fs/fs.h>
>   
>   #define CNTR_NOT_SUPPORTED	"<not supported>"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf: Remove duplicate headers
  2019-04-06 18:49 ` Mukesh Ojha
@ 2019-04-16 11:57   ` Souptick Joarder
  2019-05-11  7:33     ` Souptick Joarder
  0 siblings, 1 reply; 6+ messages in thread
From: Souptick Joarder @ 2019-04-16 11:57 UTC (permalink / raw)
  To: Mukesh Ojha
  Cc: Peter Zijlstra, Ingo Molnar, acme, Alexander Shishkin, namhyung,
	ak, Stephane Eranian, linux-kernel, Sabyasachi Gupta,
	Brajeswar Ghosh

On Sun, Apr 7, 2019 at 12:20 AM Mukesh Ojha <mojha@codeaurora.org> wrote:
>
>
> On 4/6/2019 7:06 PM, Souptick Joarder wrote:
> > Removed duplicate headers which are included twice.
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

If no further comment, can we get this patch in queue for 5.2 ?

>
> Cheers,
> -Mukesh
>
> > ---
> >   tools/perf/util/data.c                 | 1 -
> >   tools/perf/util/get_current_dir_name.c | 1 -
> >   tools/perf/util/stat-display.c         | 1 -
> >   3 files changed, 3 deletions(-)
> >
> > diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> > index 6a64f71..509a41e 100644
> > --- a/tools/perf/util/data.c
> > +++ b/tools/perf/util/data.c
> > @@ -8,7 +8,6 @@
> >   #include <unistd.h>
> >   #include <string.h>
> >   #include <asm/bug.h>
> > -#include <sys/types.h>
> >   #include <dirent.h>
> >
> >   #include "data.h"
> > diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> > index 267aa60..ebb80cd 100644
> > --- a/tools/perf/util/get_current_dir_name.c
> > +++ b/tools/perf/util/get_current_dir_name.c
> > @@ -5,7 +5,6 @@
> >   #include "util.h"
> >   #include <unistd.h>
> >   #include <stdlib.h>
> > -#include <stdlib.h>
> >
> >   /* Android's 'bionic' library, for one, doesn't have this */
> >
> > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> > index 6d043c7..7b3a16c 100644
> > --- a/tools/perf/util/stat-display.c
> > +++ b/tools/perf/util/stat-display.c
> > @@ -12,7 +12,6 @@
> >   #include "string2.h"
> >   #include "sane_ctype.h"
> >   #include "cgroup.h"
> > -#include <math.h>
> >   #include <api/fs/fs.h>
> >
> >   #define CNTR_NOT_SUPPORTED  "<not supported>"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] perf: Remove duplicate headers
  2019-04-16 11:57   ` Souptick Joarder
@ 2019-05-11  7:33     ` Souptick Joarder
  0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2019-05-11  7:33 UTC (permalink / raw)
  To: Mukesh Ojha
  Cc: Peter Zijlstra, Ingo Molnar, acme, Alexander Shishkin, namhyung,
	ak, Stephane Eranian, linux-kernel, Sabyasachi Gupta,
	Brajeswar Ghosh

On Tue, Apr 16, 2019 at 5:27 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> On Sun, Apr 7, 2019 at 12:20 AM Mukesh Ojha <mojha@codeaurora.org> wrote:
> >
> >
> > On 4/6/2019 7:06 PM, Souptick Joarder wrote:
> > > Removed duplicate headers which are included twice.
> > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
>
> If no further comment, can we get this patch in queue for 5.2 ?

Can we get this in queue for 5.2 ?

>
> >
> > Cheers,
> > -Mukesh
> >
> > > ---
> > >   tools/perf/util/data.c                 | 1 -
> > >   tools/perf/util/get_current_dir_name.c | 1 -
> > >   tools/perf/util/stat-display.c         | 1 -
> > >   3 files changed, 3 deletions(-)
> > >
> > > diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> > > index 6a64f71..509a41e 100644
> > > --- a/tools/perf/util/data.c
> > > +++ b/tools/perf/util/data.c
> > > @@ -8,7 +8,6 @@
> > >   #include <unistd.h>
> > >   #include <string.h>
> > >   #include <asm/bug.h>
> > > -#include <sys/types.h>
> > >   #include <dirent.h>
> > >
> > >   #include "data.h"
> > > diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> > > index 267aa60..ebb80cd 100644
> > > --- a/tools/perf/util/get_current_dir_name.c
> > > +++ b/tools/perf/util/get_current_dir_name.c
> > > @@ -5,7 +5,6 @@
> > >   #include "util.h"
> > >   #include <unistd.h>
> > >   #include <stdlib.h>
> > > -#include <stdlib.h>
> > >
> > >   /* Android's 'bionic' library, for one, doesn't have this */
> > >
> > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> > > index 6d043c7..7b3a16c 100644
> > > --- a/tools/perf/util/stat-display.c
> > > +++ b/tools/perf/util/stat-display.c
> > > @@ -12,7 +12,6 @@
> > >   #include "string2.h"
> > >   #include "sane_ctype.h"
> > >   #include "cgroup.h"
> > > -#include <math.h>
> > >   #include <api/fs/fs.h>
> > >
> > >   #define CNTR_NOT_SUPPORTED  "<not supported>"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] perf: Remove duplicate headers
@ 2019-06-29  4:46 Souptick Joarder
  0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2019-06-29  4:46 UTC (permalink / raw)
  To: akpm
  Cc: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung,
	linux-kernel, Souptick Joarder

Removed duplicate headers which are included twice.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
---
 tools/perf/util/data.c                 | 1 -
 tools/perf/util/get_current_dir_name.c | 1 -
 tools/perf/util/stat-display.c         | 1 -
 3 files changed, 3 deletions(-)

diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
index 6a64f71..509a41e 100644
--- a/tools/perf/util/data.c
+++ b/tools/perf/util/data.c
@@ -8,7 +8,6 @@
 #include <unistd.h>
 #include <string.h>
 #include <asm/bug.h>
-#include <sys/types.h>
 #include <dirent.h>
 
 #include "data.h"
diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
index 267aa60..ebb80cd 100644
--- a/tools/perf/util/get_current_dir_name.c
+++ b/tools/perf/util/get_current_dir_name.c
@@ -5,7 +5,6 @@
 #include "util.h"
 #include <unistd.h>
 #include <stdlib.h>
-#include <stdlib.h>
 
 /* Android's 'bionic' library, for one, doesn't have this */
 
diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index 6d043c7..7b3a16c 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -12,7 +12,6 @@
 #include "string2.h"
 #include "sane_ctype.h"
 #include "cgroup.h"
-#include <math.h>
 #include <api/fs/fs.h>
 
 #define CNTR_NOT_SUPPORTED	"<not supported>"
-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] perf: Remove duplicate headers
@ 2019-05-20 15:42 Souptick Joarder
  0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2019-05-20 15:42 UTC (permalink / raw)
  To: akpm
  Cc: peterz, mingo, acme, alexander.shishkin, jolsa, namhyung, ak,
	yao.jin, eranian, linux-kernel, Souptick Joarder

Removed duplicate headers which are included twice.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
---
 tools/perf/util/data.c                 | 1 -
 tools/perf/util/get_current_dir_name.c | 1 -
 tools/perf/util/stat-display.c         | 1 -
 3 files changed, 3 deletions(-)

diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
index 6a64f71..509a41e 100644
--- a/tools/perf/util/data.c
+++ b/tools/perf/util/data.c
@@ -8,7 +8,6 @@
 #include <unistd.h>
 #include <string.h>
 #include <asm/bug.h>
-#include <sys/types.h>
 #include <dirent.h>
 
 #include "data.h"
diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
index 267aa60..ebb80cd 100644
--- a/tools/perf/util/get_current_dir_name.c
+++ b/tools/perf/util/get_current_dir_name.c
@@ -5,7 +5,6 @@
 #include "util.h"
 #include <unistd.h>
 #include <stdlib.h>
-#include <stdlib.h>
 
 /* Android's 'bionic' library, for one, doesn't have this */
 
diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index 6d043c7..7b3a16c 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -12,7 +12,6 @@
 #include "string2.h"
 #include "sane_ctype.h"
 #include "cgroup.h"
-#include <math.h>
 #include <api/fs/fs.h>
 
 #define CNTR_NOT_SUPPORTED	"<not supported>"
-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-06-29  4:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-06 13:36 [PATCH] perf: Remove duplicate headers Souptick Joarder
2019-04-06 18:49 ` Mukesh Ojha
2019-04-16 11:57   ` Souptick Joarder
2019-05-11  7:33     ` Souptick Joarder
2019-05-20 15:42 Souptick Joarder
2019-06-29  4:46 Souptick Joarder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).