LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: AceLan Kao <acelan.kao@canonical.com>
To: David Miller <davem@davemloft.net>
Cc: James Cliburn <jcliburn@gmail.com>,
	Chris Snook <chris.snook@gmail.com>,
	rakesh@tuxera.com, netdev@vger.kernel.org,
	Emily Chien <emily.chien@canonical.com>,
	Andrew Lunn <andrew@lunn.ch>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	Johannes Stezenbach <js@sig21.net>
Subject: Re: [PATCH v2] Revert "alx: remove WoL support"
Date: Mon, 28 May 2018 13:06:31 +0800	[thread overview]
Message-ID: <CAFv23QnGJz8YUwzqmzHii=Obg8D9sb25Z4A+FFv2ze7HYXXG8g@mail.gmail.com> (raw)
In-Reply-To: <20180520.231820.868530785962553925.davem@davemloft.net>

Hi all,

Just inform you a news reported by a user who confirmed the wake up
issue can't be reproduce by the new kernel.
https://bugzilla.kernel.org/show_bug.cgi?id=61651#c126

<quote>
Guillaume de Jabrun 2018-05-27 15:12:54 UTC

I am using this patch for a long time. I was experiencing the "wake up
twice" bug, but with recent kernel version, I don't have this issue
anymore.
I can't tell which version actually fix the bug (I don't remember..).
</quote>

Best regards,
AceLan Kao.

2018-05-21 11:18 GMT+08:00 David Miller <davem@davemloft.net>:
> From: AceLan Kao <acelan.kao@canonical.com>
> Date: Mon, 21 May 2018 11:14:00 +0800
>
>> We are willing to fix the issue, but we don't have a machine to
>> reproduce it, and the WoL feature has been removed 5 years ago, it's
>> hard to find those buggy machines.
>
> Have you bothered to ask the person who did the revert?
>
>> WoL is a feature that is only used by a very small group of people,
>> and the wake up issue looks like only happens on some
>> platforms. Which means only small part of the group of people are
>> affected.
>
> One of those people was the wireless networking stack maintainer.
>
>> So, it's not a serious issue worth to remove it from alx driver.
>
> I disagree.
>
> You must fix the regression solved by the revert, before adding
> WoL support back to the driver.
>
> I'm not going to say this again.
>
> Thank you.
>

  reply	other threads:[~2018-05-28  5:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  3:28 AceLan Kao
2018-05-14 13:35 ` David Miller
2018-05-21  3:14   ` AceLan Kao
2018-05-21  3:18     ` David Miller
2018-05-28  5:06       ` AceLan Kao [this message]
2018-05-29 14:57         ` David Miller
2018-05-30  2:10 AceLan Kao
2018-05-30 13:58 ` Andrew Lunn
2018-05-31  2:13   ` AceLan Kao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFv23QnGJz8YUwzqmzHii=Obg8D9sb25Z4A+FFv2ze7HYXXG8g@mail.gmail.com' \
    --to=acelan.kao@canonical.com \
    --cc=andrew@lunn.ch \
    --cc=chris.snook@gmail.com \
    --cc=davem@davemloft.net \
    --cc=emily.chien@canonical.com \
    --cc=jcliburn@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=js@sig21.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rakesh@tuxera.com \
    --subject='Re: [PATCH v2] Revert "alx: remove WoL support"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).