LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] drm/bridge: it66121: Initialize {device,vendor}_ids
@ 2021-08-27 16:39 Paul Cercueil
  2021-08-27 16:39 ` [PATCH 2/2] drm/bridge: it66121: Wait for next bridge to be probed Paul Cercueil
  2021-08-30  9:40 ` [PATCH 1/2] drm/bridge: it66121: Initialize {device,vendor}_ids Neil Armstrong
  0 siblings, 2 replies; 5+ messages in thread
From: Paul Cercueil @ 2021-08-27 16:39 UTC (permalink / raw)
  To: Phong LE, Neil Armstrong
  Cc: Andrzej Hajda, Robert Foss, Laurent Pinchart, Jonas Karlman,
	Jernej Skrabec, David Airlie, Daniel Vetter, list, dri-devel,
	linux-kernel, Paul Cercueil

These two arrays are populated with data read from the I2C device
through regmap_read(), and the data is then compared with hardcoded
vendor/product ID values of supported chips.

However, the return value of regmap_read() was never checked. This is
fine, as long as the two arrays are zero-initialized, so that we don't
compare the vendor/product IDs against whatever garbage is left on the
stack.

Address this issue by zero-initializing these two arrays.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 drivers/gpu/drm/bridge/ite-it66121.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 2f2a09adb4bc..b130d01147c6 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -889,7 +889,7 @@ static irqreturn_t it66121_irq_threaded_handler(int irq, void *dev_id)
 static int it66121_probe(struct i2c_client *client,
 			 const struct i2c_device_id *id)
 {
-	u32 vendor_ids[2], device_ids[2], revision_id;
+	u32 revision_id, vendor_ids[2] = { 0 }, device_ids[2] = { 0 };
 	struct device_node *ep;
 	int ret;
 	struct it66121_ctx *ctx;
-- 
2.33.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-31 14:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 16:39 [PATCH 1/2] drm/bridge: it66121: Initialize {device,vendor}_ids Paul Cercueil
2021-08-27 16:39 ` [PATCH 2/2] drm/bridge: it66121: Wait for next bridge to be probed Paul Cercueil
2021-08-30  9:40   ` Neil Armstrong
2021-08-30  9:40 ` [PATCH 1/2] drm/bridge: it66121: Initialize {device,vendor}_ids Neil Armstrong
2021-08-31 14:22   ` Robert Foss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).