From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10018C4320A for ; Wed, 18 Aug 2021 02:57:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D842B60C3F for ; Wed, 18 Aug 2021 02:57:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235496AbhHRC5y (ORCPT ); Tue, 17 Aug 2021 22:57:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234261AbhHRC5x (ORCPT ); Tue, 17 Aug 2021 22:57:53 -0400 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F9BDC0613C1 for ; Tue, 17 Aug 2021 19:57:19 -0700 (PDT) Received: by mail-yb1-xb2b.google.com with SMTP id g26so2484980ybe.0 for ; Tue, 17 Aug 2021 19:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E8J1M8TLojn9lNRFCWALG+xqr0khqK2ghlCL+ZC08FY=; b=MabUach2AGIkoGUn1LDVwxrSHsqBJSDF/BKO0y7/EcAkJ9sCwtzJbIwJdTHbx3GN7p 8kIG/jVLcxrsWOXJlwXRmuCn3I41YUAjzBndeTLst7n+SKYrv4KmTosi8OVRgFVQIKSr aPUPFoqw50AH0kDfWlxiAz9mfQkvmL2uRr1qNsIo38a09+dLbqQCofKYqG9LFEKFMOWr 94+dJ8H/ujR1vnip5z38VTVdVIuMI63l9Gscml9Oth2gr+tMnx8K9Au7x7YrgKVcEU34 +sdTQkTDLimsebm9Z6BzIdNx8sE51k+1JCpGC1a3Rwv4NYybgOSyqpSjpunh5KUgz8bz +rpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E8J1M8TLojn9lNRFCWALG+xqr0khqK2ghlCL+ZC08FY=; b=dLlIxfZt5AaWORYDjxGH83yPwhqTYOqALjeqfER8FRoMLl7uKMcbjDC/xtp0LCIgpu 9piwxGfCu8yWQcydliu3PK0YKlIwkohPq3DmTWKgfkDuUDugFKGJ6CWF662pg4Wxvfeq 2b3CPVCRqTymiZrz+J6ImAwPb62k7qP1413ivEvvJIbEi6d/Ldv9rlf7IcAKI2R5XX4t BlweUO3Q1mIJNxCUiaBIiT0LSOKNY4imn81MQe+RWRQt/q7KdF60svEUT+ioMa1tF39+ CNXuzDjOjhzFJ08merCGko2/FmUHBVhrrlzYKXnKEG/fl1qostxCl/hS4SR8EWVrpa0j kkSw== X-Gm-Message-State: AOAM532dNolTkdOBmctgNd5mgI+g7rqma2LMB4etmEGhbaF0gIZEPFO0 smW+SO/wG8GX7jxFIwPTgSXR24BXSBrAjQh6bv0qDw== X-Google-Smtp-Source: ABdhPJxI6FTcE3c47Wn0i+htLO57WaK/N9r5UacnETGWbX71+m63BkfRB2kVMW33iIPN/Rimw1sywjsUf/wkZujNgKk= X-Received: by 2002:a25:81ce:: with SMTP id n14mr8943857ybm.32.1629255438297; Tue, 17 Aug 2021 19:57:18 -0700 (PDT) MIME-Version: 1.0 References: <20210817180841.3210484-1-saravanak@google.com> <20210817180841.3210484-2-saravanak@google.com> In-Reply-To: From: Saravana Kannan Date: Tue, 17 Aug 2021 19:56:42 -0700 Message-ID: Subject: Re: [PATCH net v2 1/3] net: mdio-mux: Delete unnecessary devm_kfree To: Andrew Lunn Cc: Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Marc Zyngier , Neil Armstrong , Kevin Hilman , kernel-team@android.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 17, 2021 at 2:10 PM Andrew Lunn wrote: > > On Tue, Aug 17, 2021 at 11:08:39AM -0700, Saravana Kannan wrote: > > The whole point of devm_* APIs is that you don't have to undo them if you > > are returning an error that's going to get propagated out of a probe() > > function. So delete unnecessary devm_kfree() call in the error return path. > > > > Signed-off-by: Saravana Kannan > > Reviewed-by: Andrew Lunn > > Acked-by: Marc Zyngier > > Tested-by: Marc Zyngier > > Acked-by: Kevin Hilman > > Tested-by: Kevin Hilman > > Please add a Fixes: tag, since you want this in stable. > > All three patches need fixes tags, possibly different for each patch? I generally ask for patches to be picked up by stable only if it fixes a bug that puts the kernel in a bad state or if it fixes an issue someone actually reported on the stable kernel. In this case, it's just failing device probes in some cases and I didn't think that met the bar for stable. But if you think they should, then that's fine by me. I'll send out v3 patches with Fixes. I'm fairly sure these issues were present since the time mdio-mux was added. Hopefully v3 will be the last version I have to send out :) -Saravana