LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Saravana Kannan <saravanak@google.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	John Stultz <john.stultz@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
	kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/5] driver core: fw_devlink: Improve handling of cyclic dependencies
Date: Tue, 14 Sep 2021 01:01:52 -0700	[thread overview]
Message-ID: <CAGETcx_s59Xga26uOp48g8eCr72ysgCtfu3eCQ8eK7F+dDau1w@mail.gmail.com> (raw)
In-Reply-To: <7756112c-0378-f48b-ef5a-aafc994dc662@samsung.com>

On Mon, Sep 13, 2021 at 11:16 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> On 14.09.2021 06:39, Saravana Kannan wrote:
> > When we have a dependency of the form:
> >
> > Device-A -> Device-C
> >       Device-B
> >
> > Device-C -> Device-B
> >
> > Where,
> > * Indentation denotes "child of" parent in previous line.
> > * X -> Y denotes X is consumer of Y based on firmware (Eg: DT).
> >
> > We have cyclic dependency: device-A -> device-C -> device-B -> device-A
> >
> > fw_devlink current treats device-C -> device-B dependency as an invalid
> > dependency and doesn't enforce it but leaves the rest of the
> > dependencies as is.
> >
> > While the current behavior is necessary, it is not sufficient if the
> > false dependency in this example is actually device-A -> device-C. When
> > this is the case, device-C will correctly probe defer waiting for
> > device-B to be added, but device-A will be incorrectly probe deferred by
> > fw_devlink waiting on device-C to probe successfully. Due to this, none
> > of the devices in the cycle will end up probing.
> >
> > To fix this, we need to go relax all the dependencies in the cycle like
> > we already do in the other instances where fw_devlink detects cycles.
> > A real world example of this was reported[1] and analyzed[2].
> >
> > [1] - https://lore.kernel.org/lkml/0a2c4106-7f48-2bb5-048e-8c001a7c3fda@samsung.com/
> > [2] - https://lore.kernel.org/lkml/CAGETcx8peaew90SWiux=TyvuGgvTQOmO4BFALz7aj0Za5QdNFQ@mail.gmail.com/
> > Fixes: f9aa460672c9 ("driver core: Refactor fw_devlink feature")
> > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

Thanks!

-Saravana

> > Signed-off-by: Saravana Kannan <saravanak@google.com>
> > ---
> >   drivers/base/core.c | 17 ++++++++++++-----
> >   1 file changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > index e65dd803a453..316df6027093 100644
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -1772,14 +1772,21 @@ static int fw_devlink_create_devlink(struct device *con,
> >        * be broken by applying logic. Check for these types of cycles and
> >        * break them so that devices in the cycle probe properly.
> >        *
> > -      * If the supplier's parent is dependent on the consumer, then
> > -      * the consumer-supplier dependency is a false dependency. So,
> > -      * treat it as an invalid link.
> > +      * If the supplier's parent is dependent on the consumer, then the
> > +      * consumer and supplier have a cyclic dependency. Since fw_devlink
> > +      * can't tell which of the inferred dependencies are incorrect, don't
> > +      * enforce probe ordering between any of the devices in this cyclic
> > +      * dependency. Do this by relaxing all the fw_devlink device links in
> > +      * this cycle and by treating the fwnode link between the consumer and
> > +      * the supplier as an invalid dependency.
> >        */
> >       sup_dev = fwnode_get_next_parent_dev(sup_handle);
> >       if (sup_dev && device_is_dependent(con, sup_dev)) {
> > -             dev_dbg(con, "Not linking to %pfwP - False link\n",
> > -                     sup_handle);
> > +             dev_info(con, "Fixing up cyclic dependency with %pfwP (%s)\n",
> > +                      sup_handle, dev_name(sup_dev));
> > +             device_links_write_lock();
> > +             fw_devlink_relax_cycle(con, sup_dev);
> > +             device_links_write_unlock();
> >               ret = -EINVAL;
> >       } else {
> >               /*
>
> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
>

  reply	other threads:[~2021-09-14  8:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  4:39 [PATCH v1 0/5] fw_devlink improvements Saravana Kannan
2021-09-14  4:39 ` [PATCH v1 1/5] driver core: fw_devlink: Improve handling of cyclic dependencies Saravana Kannan
2021-09-14  6:16   ` Marek Szyprowski
2021-09-14  8:01     ` Saravana Kannan [this message]
2021-09-14 12:35   ` Rob Herring
2021-09-14 16:23     ` Saravana Kannan
2021-09-14  4:39 ` [PATCH v1 2/5] driver core: Set deferred probe reason when deferred by driver core Saravana Kannan
2021-09-14  7:01   ` Geert Uytterhoeven
2021-09-14  7:58     ` Saravana Kannan
2021-09-15  5:41       ` Saravana Kannan
2021-09-14  4:39 ` [PATCH v1 3/5] driver core: Create __fwnode_link_del() helper function Saravana Kannan
2021-09-14  7:04   ` Geert Uytterhoeven
2021-09-14  7:46     ` Saravana Kannan
2021-09-14  4:39 ` [PATCH v1 4/5] driver core: Add debug logs when fwnode links are added/deleted Saravana Kannan
2021-09-14  7:09   ` Geert Uytterhoeven
2021-09-14  4:39 ` [PATCH v1 5/5] driver core: Add fw_devlink.debug command line boolean parameter Saravana Kannan
2021-09-14 15:10   ` Andrew Lunn
2021-09-14 16:27     ` Saravana Kannan
2021-09-14 16:43       ` Andrew Lunn
2021-09-14 16:52         ` Rob Herring
2021-09-14 17:31           ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGETcx_s59Xga26uOp48g8eCr72ysgCtfu3eCQ8eK7F+dDau1w@mail.gmail.com \
    --to=saravanak@google.com \
    --cc=andrew@lunn.ch \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=olteanv@gmail.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v1 1/5] driver core: fw_devlink: Improve handling of cyclic dependencies' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).