LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel Kurtz <djkurtz@chromium.org>
To: Akshu Agrawal <akshu.agrawal@amd.com>
Cc: Alexander.Deucher@amd.com,
	Mike Turquette <mturquette@baylibre.com>,
	sboyd@kernel.org, christian.koenig@amd.com,
	Dave Airlie <airlied@redhat.com>,
	Shaoyun.Liu@amd.com, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ACPI: APD: Add AMD misc clock handler support
Date: Wed, 09 May 2018 15:59:14 +0000	[thread overview]
Message-ID: <CAGS+omCy8B343pW-b26aEuRLyYHiQjMO2Rph4L6_x37uJ7r6vA@mail.gmail.com> (raw)
In-Reply-To: <1525859941-23654-3-git-send-email-akshu.agrawal@amd.com>

On Wed, May 9, 2018 at 4:01 AM Akshu Agrawal <akshu.agrawal@amd.com> wrote:

> AMD SoC exposes clock for general purpose use. The clock registration
> is done in clk-st driver. The MMIO mapping are passed on to the
> clock driver for accessing the registers.
> The misc clock handler will create MMIO mappings to access the
> clock registers and enable the clock driver to expose the clock
> for use of drivers which will connect to it.

> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>

Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

> ---
> v2: Submitted with dependent patch, removed unneeded kfree for
devm_kzalloc
> v3: used devm_ioremap and fix coccinelle warning
>   drivers/acpi/acpi_apd.c | 47
+++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 47 insertions(+)

> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index d553b00..2664452 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -11,6 +11,7 @@
>    */

>   #include <linux/clk-provider.h>
> +#include <linux/platform_data/clk-st.h>
>   #include <linux/platform_device.h>
>   #include <linux/pm_domain.h>
>   #include <linux/clkdev.h>
> @@ -72,6 +73,47 @@ static int acpi_apd_setup(struct apd_private_data
*pdata)
>   }

>   #ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
> +
> +static int misc_check_res(struct acpi_resource *ares, void *data)
> +{
> +       struct resource res;
> +
> +       return !acpi_dev_resource_memory(ares, &res);
> +}
> +
> +static int st_misc_setup(struct apd_private_data *pdata)
> +{
> +       struct acpi_device *adev = pdata->adev;
> +       struct platform_device *clkdev;
> +       struct st_clk_data *clk_data;
> +       struct resource_entry *rentry;
> +       struct list_head resource_list;
> +       int ret;
> +
> +       clk_data = devm_kzalloc(&adev->dev, sizeof(*clk_data),
GFP_KERNEL);
> +       if (!clk_data)
> +               return -ENOMEM;
> +
> +       INIT_LIST_HEAD(&resource_list);
> +       ret = acpi_dev_get_resources(adev, &resource_list, misc_check_res,
> +                                    NULL);
> +       if (ret < 0)
> +               return -ENOENT;
> +
> +       list_for_each_entry(rentry, &resource_list, node) {
> +               clk_data->base = devm_ioremap(&adev->dev,
rentry->res->start,
> +                                             resource_size(rentry->res));
> +               break;
> +       }
> +
> +       acpi_dev_free_resource_list(&resource_list);
> +
> +       clkdev = platform_device_register_data(&adev->dev, "clk-st",
> +                                              PLATFORM_DEVID_NONE,
clk_data,
> +                                              sizeof(*clk_data));
> +       return PTR_ERR_OR_ZERO(clkdev);
> +}
> +
>   static const struct apd_device_desc cz_i2c_desc = {
>          .setup = acpi_apd_setup,
>          .fixed_clk_rate = 133000000,
> @@ -94,6 +136,10 @@ static int acpi_apd_setup(struct apd_private_data
*pdata)
>          .fixed_clk_rate = 48000000,
>          .properties = uart_properties,
>   };
> +
> +static const struct apd_device_desc st_misc_desc = {
> +       .setup = st_misc_setup,
> +};
>   #endif

>   #ifdef CONFIG_ARM64
> @@ -179,6 +225,7 @@ static int acpi_apd_create_device(struct acpi_device
*adev,
>          { "AMD0020", APD_ADDR(cz_uart_desc) },
>          { "AMDI0020", APD_ADDR(cz_uart_desc) },
>          { "AMD0030", },
> +       { "AMD0040", APD_ADDR(st_misc_desc)},
>   #endif
>   #ifdef CONFIG_ARM64
>          { "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
> --
> 1.9.1

  reply	other threads:[~2018-05-09 15:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09  9:58 [PATCH v3 0/2] Add support for general system clock on ST AMD platform Akshu Agrawal
2018-05-09  9:59 ` [PATCH v5 1/2] clk: x86: Add ST oscout platform clock Akshu Agrawal
2018-05-09 15:58   ` Daniel Kurtz
2018-05-15  9:32   ` Rafael J. Wysocki
2018-05-15  9:39     ` Agrawal, Akshu
2018-05-15 21:14       ` Stephen Boyd
2018-05-16  8:23         ` Rafael J. Wysocki
2018-05-16 21:18           ` Stephen Boyd
2018-05-15 21:11   ` Stephen Boyd
2018-05-09  9:59 ` [PATCH v3 2/2] ACPI: APD: Add AMD misc clock handler support Akshu Agrawal
2018-05-09 15:59   ` Daniel Kurtz [this message]
2018-05-23 11:32 ` [PATCH v3 0/2] Add support for general system clock on ST AMD platform Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGS+omCy8B343pW-b26aEuRLyYHiQjMO2Rph4L6_x37uJ7r6vA@mail.gmail.com \
    --to=djkurtz@chromium.org \
    --cc=Alexander.Deucher@amd.com \
    --cc=Shaoyun.Liu@amd.com \
    --cc=airlied@redhat.com \
    --cc=akshu.agrawal@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rjw@rjwysocki.net \
    --cc=sboyd@kernel.org \
    --subject='Re: [PATCH v3 2/2] ACPI: APD: Add AMD misc clock handler support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).