LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Will Deacon <will.deacon@arm.com>,
Andy Lutomirski <luto@kernel.org>, Joerg Roedel <jroedel@suse.de>,
Daniel Micay <danielmicay@gmail.com>
Subject: Re: [PATCH 1/2] x86/pkeys: copy pkey state at fork()
Date: Tue, 8 Jan 2019 16:56:03 -0800 [thread overview]
Message-ID: <CAGXu5j+Jy=3OcpcF21n=1khArR8DscLXSPnBpT1Jqn4Q7NbMvw@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5jLbWT62xHk1jVCeo8nrqCj9ECSqGpEFWKXP6qd5jxiRpw@mail.gmail.com>
On Tue, Nov 20, 2018 at 1:14 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Fri, Oct 26, 2018 at 12:59 PM, Dave Hansen <dave.hansen@intel.com> wrote:
> > On 10/26/18 12:51 PM, Dave Hansen wrote:
> > ...
> >> The result is that, after a fork(), the child's pkey state ends up
> >> looking like it does after an execve(), which is totally wrong. pkeys
> >> that are already allocated can be allocated again, for instance.
> >
> > One thing I omitted. This was very nicely discovered and reported by
> > danielmicay@gmail.com. Thanks, Daniel!
>
> Thread ping. Is there a v2 of this, or can this go in as-is? Looks good to me:
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Ingo, can you take these two patches? Use of pkeys is still buggy
without it. (And probably should have a Cc: stable tag too.)
-Kees
--
Kees Cook
prev parent reply other threads:[~2019-01-09 0:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 19:51 [PATCH 1/2] x86/pkeys: copy pkey state at fork() Dave Hansen
2018-10-26 19:51 ` [PATCH 2/2] x86/selftests/pkeys: fork() to check for state being preserved Dave Hansen
2018-10-26 19:59 ` [PATCH 1/2] x86/pkeys: copy pkey state at fork() Dave Hansen
2018-10-26 21:39 ` Daniel Micay
2018-10-26 22:12 ` Andy Lutomirski
2018-10-26 22:56 ` Daniel Micay
2018-10-29 6:36 ` Ingo Molnar
2018-10-29 8:55 ` Daniel Micay
2018-11-20 21:14 ` Kees Cook
2019-01-09 0:56 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5j+Jy=3OcpcF21n=1khArR8DscLXSPnBpT1Jqn4Q7NbMvw@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=danielmicay@gmail.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).