LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Rom Lemarchand <romlem@google.com>,
	Mark Salyzyn <salyzyn@google.com>,
	Android Kernel Team <kernel-team@android.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Valentin Rothberg <valentinrothberg@gmail.com>,
	Greg Hackmann <ghackmann@google.com>,
	Elliott Hughes <enh@google.com>,
	Todd Poynor <toddpoynor@google.com>
Subject: Re: [PATCH] staging: Remove logger and alarm-dev from android Makefile
Date: Tue, 27 Jan 2015 09:16:31 -0800	[thread overview]
Message-ID: <CAGXu5jJRNoXGYjmnWPFG_of6FS+TyoEHRV05tb94_wP9Cmi1Zg@mail.gmail.com> (raw)
In-Reply-To: <1422372141-2440-1-git-send-email-john.stultz@linaro.org>

On Tue, Jan 27, 2015 at 7:22 AM, John Stultz <john.stultz@linaro.org> wrote:
> My previous patches deleting logger and alarm-dev from staging
> missed the android Makefile.
>
> This patch cleans up the Makefile to remove the now non-existent
> files.
>
> Cc: Rom Lemarchand <romlem@google.com>,
> Cc: Mark Salyzyn <salyzyn@google.com>,
> Cc: Kees Cook <keescook@chromium.org>,
> Cc: Android Kernel Team <kernel-team@android.com>,
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
> Cc: Greg Hackmann <ghackmann@google.com>,
> Cc: Elliott Hughes <enh@google.com>,
> Cc: Todd Poynor <toddpoynor@google.com>,
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: John Stultz <john.stultz@linaro.org>

Looks right to me. :)

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  drivers/staging/android/Makefile | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/android/Makefile b/drivers/staging/android/Makefile
> index 479b2b8..c7b6c99 100644
> --- a/drivers/staging/android/Makefile
> +++ b/drivers/staging/android/Makefile
> @@ -3,10 +3,8 @@ ccflags-y += -I$(src)                  # needed for trace events
>  obj-y                                  += ion/
>
>  obj-$(CONFIG_ASHMEM)                   += ashmem.o
> -obj-$(CONFIG_ANDROID_LOGGER)           += logger.o
>  obj-$(CONFIG_ANDROID_TIMED_OUTPUT)     += timed_output.o
>  obj-$(CONFIG_ANDROID_TIMED_GPIO)       += timed_gpio.o
>  obj-$(CONFIG_ANDROID_LOW_MEMORY_KILLER)        += lowmemorykiller.o
> -obj-$(CONFIG_ANDROID_INTF_ALARM_DEV)   += alarm-dev.o
>  obj-$(CONFIG_SYNC)                     += sync.o sync_debug.o
>  obj-$(CONFIG_SW_SYNC)                  += sw_sync.o
> --
> 1.9.1
>



-- 
Kees Cook
Chrome OS Security

      reply	other threads:[~2015-01-27 17:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 21:42 [PATCH 1/2][RFC] staging: Remove the Android alarm-dev driver John Stultz
2015-01-20 21:42 ` [PATCH 2/2][RFC] staging: Remove the Android logger driver John Stultz
2015-01-20 22:01   ` Greg KH
2015-01-25 12:11   ` Greg KH
2015-01-26 20:07     ` [PATCH] " John Stultz
2015-01-27  9:28       ` Paul Bolle
2015-01-27  9:24 ` [PATCH 1/2][RFC] staging: Remove the Android alarm-dev driver Paul Bolle
2015-01-27 15:06   ` John Stultz
2015-01-27 15:22   ` [PATCH] staging: Remove logger and alarm-dev from android Makefile John Stultz
2015-01-27 17:16     ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGXu5jJRNoXGYjmnWPFG_of6FS+TyoEHRV05tb94_wP9Cmi1Zg@mail.gmail.com \
    --to=keescook@chromium.org \
    --cc=enh@google.com \
    --cc=ghackmann@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=romlem@google.com \
    --cc=salyzyn@google.com \
    --cc=toddpoynor@google.com \
    --cc=valentinrothberg@gmail.com \
    --subject='Re: [PATCH] staging: Remove logger and alarm-dev from android Makefile' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).