LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] selftests:firmware: fixes a call to a wrong function name  
@ 2018-04-23 14:10 Jeffrin Jose T
  2018-04-23 16:39 ` Kees Cook
  0 siblings, 1 reply; 4+ messages in thread
From: Jeffrin Jose T @ 2018-04-23 14:10 UTC (permalink / raw)
  To: shuah, gregkh, keescook, mcgrof
  Cc: linux-kselftest, linux-kernel, Jeffrin Jose T, Jeffrin Jose T

 This is a patch to the tools/testing/selftests/firmware/fw_run_tests.sh
 file which fixes a bug which calls to a wrong function name,which in turn
 blocks the execution of certain tests.
 
Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
Acked-by: Kees Cook <keescook@chromium.org>

---
 tools/testing/selftests/firmware/fw_run_tests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/firmware/fw_run_tests.sh b/tools/testing/selftests/firmware/fw_run_tests.sh
index 06d638e9dc62..cffdd4eb0a57 100755
--- a/tools/testing/selftests/firmware/fw_run_tests.sh
+++ b/tools/testing/selftests/firmware/fw_run_tests.sh
@@ -66,5 +66,5 @@ if [ -f $FW_FORCE_SYSFS_FALLBACK ]; then
 	run_test_config_0003
 else
 	echo "Running basic kernel configuration, working with your config"
-	run_test
+	run_tests
 fi
-- 
2.17.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] selftests:firmware: fixes a call to a wrong function name
  2018-04-23 14:10 [PATCH] selftests:firmware: fixes a call to a wrong function name Jeffrin Jose T
@ 2018-04-23 16:39 ` Kees Cook
  2018-04-25 15:26   ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2018-04-23 16:39 UTC (permalink / raw)
  To: Shuah Khan, Jeffrin Jose T, Luis R. Rodriguez
  Cc: Greg KH, open list:KERNEL SELFTEST FRAMEWORK, LKML, Jeffrin Jose T

On Mon, Apr 23, 2018 at 7:10 AM, Jeffrin Jose T <ahiliation@yahoo.co.in> wrote:
>  This is a patch to the tools/testing/selftests/firmware/fw_run_tests.sh
>  file which fixes a bug which calls to a wrong function name,which in turn
>  blocks the execution of certain tests.
>
> Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
>
> ---
>  tools/testing/selftests/firmware/fw_run_tests.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/firmware/fw_run_tests.sh b/tools/testing/selftests/firmware/fw_run_tests.sh
> index 06d638e9dc62..cffdd4eb0a57 100755
> --- a/tools/testing/selftests/firmware/fw_run_tests.sh
> +++ b/tools/testing/selftests/firmware/fw_run_tests.sh
> @@ -66,5 +66,5 @@ if [ -f $FW_FORCE_SYSFS_FALLBACK ]; then
>         run_test_config_0003
>  else
>         echo "Running basic kernel configuration, working with your config"
> -       run_test
> +       run_tests
>  fi

I find it confusing that run_tests() uses $1 and $2 but later ignores
them unless -f $FW_FORCE_SYSFS_FALLBACK, which is checked at both the
top level and in proc_set_*_fallback()... I'd expected the test to
happen only in run_tests() and have it removed from from
proc_set_*_fallback().

Regardless, the above patch is correct to run the tests. :)

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

-- 
Kees Cook
Pixel Security

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] selftests:firmware: fixes a call to a wrong function name
  2018-04-23 16:39 ` Kees Cook
@ 2018-04-25 15:26   ` Greg KH
  2018-04-25 15:30     ` Shuah Khan
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2018-04-25 15:26 UTC (permalink / raw)
  To: Kees Cook
  Cc: Shuah Khan, Jeffrin Jose T, Luis R. Rodriguez,
	open list:KERNEL SELFTEST FRAMEWORK, LKML, Jeffrin Jose T

On Mon, Apr 23, 2018 at 09:39:02AM -0700, Kees Cook wrote:
> On Mon, Apr 23, 2018 at 7:10 AM, Jeffrin Jose T <ahiliation@yahoo.co.in> wrote:
> >  This is a patch to the tools/testing/selftests/firmware/fw_run_tests.sh
> >  file which fixes a bug which calls to a wrong function name,which in turn
> >  blocks the execution of certain tests.
> >
> > Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
> >
> > ---
> >  tools/testing/selftests/firmware/fw_run_tests.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/firmware/fw_run_tests.sh b/tools/testing/selftests/firmware/fw_run_tests.sh
> > index 06d638e9dc62..cffdd4eb0a57 100755
> > --- a/tools/testing/selftests/firmware/fw_run_tests.sh
> > +++ b/tools/testing/selftests/firmware/fw_run_tests.sh
> > @@ -66,5 +66,5 @@ if [ -f $FW_FORCE_SYSFS_FALLBACK ]; then
> >         run_test_config_0003
> >  else
> >         echo "Running basic kernel configuration, working with your config"
> > -       run_test
> > +       run_tests
> >  fi
> 
> I find it confusing that run_tests() uses $1 and $2 but later ignores
> them unless -f $FW_FORCE_SYSFS_FALLBACK, which is checked at both the
> top level and in proc_set_*_fallback()... I'd expected the test to
> happen only in run_tests() and have it removed from from
> proc_set_*_fallback().
> 
> Regardless, the above patch is correct to run the tests. :)

Thanks, I'll go queue this up.

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] selftests:firmware: fixes a call to a wrong function name
  2018-04-25 15:26   ` Greg KH
@ 2018-04-25 15:30     ` Shuah Khan
  0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2018-04-25 15:30 UTC (permalink / raw)
  To: Greg KH, Kees Cook
  Cc: Jeffrin Jose T, Luis R. Rodriguez,
	open list:KERNEL SELFTEST FRAMEWORK, LKML, Jeffrin Jose T,
	Shuah Khan

On 04/25/2018 09:26 AM, Greg KH wrote:
> On Mon, Apr 23, 2018 at 09:39:02AM -0700, Kees Cook wrote:
>> On Mon, Apr 23, 2018 at 7:10 AM, Jeffrin Jose T <ahiliation@yahoo.co.in> wrote:
>>>  This is a patch to the tools/testing/selftests/firmware/fw_run_tests.sh
>>>  file which fixes a bug which calls to a wrong function name,which in turn
>>>  blocks the execution of certain tests.
>>>
>>> Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
>>>
>>> ---
>>>  tools/testing/selftests/firmware/fw_run_tests.sh | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/firmware/fw_run_tests.sh b/tools/testing/selftests/firmware/fw_run_tests.sh
>>> index 06d638e9dc62..cffdd4eb0a57 100755
>>> --- a/tools/testing/selftests/firmware/fw_run_tests.sh
>>> +++ b/tools/testing/selftests/firmware/fw_run_tests.sh
>>> @@ -66,5 +66,5 @@ if [ -f $FW_FORCE_SYSFS_FALLBACK ]; then
>>>         run_test_config_0003
>>>  else
>>>         echo "Running basic kernel configuration, working with your config"
>>> -       run_test
>>> +       run_tests
>>>  fi
>>
>> I find it confusing that run_tests() uses $1 and $2 but later ignores
>> them unless -f $FW_FORCE_SYSFS_FALLBACK, which is checked at both the
>> top level and in proc_set_*_fallback()... I'd expected the test to
>> happen only in run_tests() and have it removed from from
>> proc_set_*_fallback().
>>
>> Regardless, the above patch is correct to run the tests. :)
> 
> Thanks, I'll go queue this up.
> 
> greg k-h
> 

Thanks. This probably has dependency on firmware tree.

Acked-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>

-- Shuah

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-04-25 15:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-23 14:10 [PATCH] selftests:firmware: fixes a call to a wrong function name Jeffrin Jose T
2018-04-23 16:39 ` Kees Cook
2018-04-25 15:26   ` Greg KH
2018-04-25 15:30     ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).