LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: jic23@jic23.retrosnub.co.uk
Cc: Rob Herring <robh@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	linux-iio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Vasily Khoruzhick <anarsoul@gmail.com>,
	Quentin Schulz <quentin.schulz@free-electrons.com>,
	devicetree <devicetree@vger.kernel.org>,
	oskari@lemmela.net, linux-gpio@vger.kernel.org,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Quentin Schulz <quentin.schulz@bootlin.com>
Subject: Re: [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings
Date: Wed, 31 Oct 2018 10:29:59 +0800	[thread overview]
Message-ID: <CAGb2v65JKj_7VcEr1KuZVop85hn-3h73NrExprpmLbKZiosD5Q@mail.gmail.com> (raw)
In-Reply-To: <20181029130757.m5okrfvusjl5fu5m@qschulz>

On Mon, Oct 29, 2018 at 9:10 PM Quentin Schulz
<quentin.schulz@bootlin.com> wrote:
>
> Hi Jonathan,
>
> On Sun, Oct 28, 2018 at 03:40:11PM +0000, Jonathan Cameron wrote:
> > On Wed, 24 Oct 2018 08:56:33 -0500
> > Rob Herring <robh@kernel.org> wrote:
> >
> > > On Tue, 23 Oct 2018 21:53:23 +0300, Oskari Lemmela wrote:
> > > > The AXP803 ADC is compatible with AXP813 ADC, but add
> > > > specific compatible for it.
> > > >
> > > > Signed-off-by: Oskari Lemmela <oskari@lemmela.net>
> > > > ---
> > > >  Documentation/devicetree/bindings/iio/adc/axp20x_adc.txt | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > >
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > This doesn't seem to have any dependencies with the other patches
> > so applied to the togreg branch of iio.git and pushed out as testing
> > for the autobuilders to ignore.  However I am a little curious to know
> > why we would add the ID and then not use it (that I can see)?
> >
>
> Sometimes with Allwinner (and X-Powers), two IPs seem identical until we
> discover something that is slightly different. When this happens, we
> have to add a compatible to differentiate both. However, we would also
> need to change the Device Tree to change the compatible. We would need
> to handle the driver behaviour for both Device Trees.
>
> So better anticipate a possible difference so that we don't have to do
> some hacks in the driver to handle the device correctly.
>
> As always, Chen-Yu or Maxime may know better so I'm just stating what I
> seem to recall.

With Allwinner stuff (X-Powers included), sometimes the documents are
incomplete or have errors. We tend to add a model-specific compatible
just in case things turn out not to be so compatible, unless someone
has triple-checked everything, documents and actual hardware included.

However we don't actually document these, so this patch isn't strictly
needed. (I suppose this might annoy the device tree binding maintainers.)

ChenYu

  reply	other threads:[~2018-10-31  2:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 18:53 [PATCH v5 00/11] AXP8x3 AC and battery power supply support Oskari Lemmela
2018-10-23 18:53 ` [PATCH v5 01/11] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding Oskari Lemmela
2018-10-23 18:53 ` [PATCH v5 02/11] dt-bindings: power: supply: axp20x: add AXP803 power bindings Oskari Lemmela
2018-10-24 13:55   ` Rob Herring
2018-10-31  2:38   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 03/11] dt-bindings: gpio: gpio-axp209: add AXP803 GPIO bindings Oskari Lemmela
2018-10-24 13:55   ` Rob Herring
2018-10-31  3:00   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings Oskari Lemmela
2018-10-24 13:56   ` Rob Herring
2018-10-28 15:40     ` Jonathan Cameron
2018-10-29 13:07       ` Quentin Schulz
2018-10-31  2:29         ` Chen-Yu Tsai [this message]
2018-11-03 10:21           ` Jonathan Cameron
2018-11-05  5:47             ` Chen-Yu Tsai
2018-11-11 15:30               ` Jonathan Cameron
2018-10-23 18:53 ` [PATCH v5 05/11] ARM: dts: axp81x: add AC power supply subnode Oskari Lemmela
2018-10-23 18:53 ` [PATCH v5 06/11] arm64: dts: allwinner: axp803: add AC and battery power supplies Oskari Lemmela
2018-10-31  3:04   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 07/11] arm64: dts: allwinner: a64: sopine-baseboard: enable " Oskari Lemmela
2018-10-31  3:05   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 08/11] arm64: dts: allwinner: a64: pinebook: " Oskari Lemmela
2018-10-31  3:05   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 09/11] power: supply: add AC power supply driver for AXP813 Oskari Lemmela
2018-10-25 10:23   ` Lee Jones
2018-10-31  2:55   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 10/11] mfd: axp20x: Add AC power supply cell " Oskari Lemmela
2018-10-25 10:23   ` Lee Jones
2018-10-23 18:53 ` [PATCH v5 11/11] mfd: axp20x: Add supported cells for AXP803 Oskari Lemmela
2018-10-25 10:24   ` Lee Jones
2018-10-25 13:30 ` [PATCH v5 00/11] AXP8x3 AC and battery power supply support Sebastian Reichel
2018-10-31  2:33   ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v65JKj_7VcEr1KuZVop85hn-3h73NrExprpmLbKZiosD5Q@mail.gmail.com \
    --to=wens@csie.org \
    --cc=anarsoul@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@jic23.retrosnub.co.uk \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=oskari@lemmela.net \
    --cc=quentin.schulz@bootlin.com \
    --cc=quentin.schulz@free-electrons.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --subject='Re: [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).