LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: oskari@lemmela.net
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Vasily Khoruzhick <anarsoul@gmail.com>,
	Quentin Schulz <quentin.schulz@free-electrons.com>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v5 03/11] dt-bindings: gpio: gpio-axp209: add AXP803 GPIO bindings
Date: Wed, 31 Oct 2018 11:00:51 +0800	[thread overview]
Message-ID: <CAGb2v666Vn_GdFwT4MXfbD7Gb1UC+gwGdVhquKH09Ld_Q3QmtA@mail.gmail.com> (raw)
In-Reply-To: <20181023185330.10472-4-oskari@lemmela.net>

On Wed, Oct 24, 2018 at 2:54 AM Oskari Lemmela <oskari@lemmela.net> wrote:
>
> The AXP803 GPIO is compatible with AXP813 GPIO, but add
> specific compatible for it.
>
> Signed-off-by: Oskari Lemmela <oskari@lemmela.net>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-axp209.txt | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> index fc42b2caa06d..5337a21d7bcf 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt
> @@ -11,6 +11,7 @@ This driver employs the per-pin muxing pattern.
>  Required properties:
>  - compatible: Should be one of:
>         - "x-powers,axp209-gpio"
> +       - "x-powers,axp803-gpio"
>         - "x-powers,axp813-gpio"
>  - #gpio-cells: Should be two. The first cell is the pin number and the
>    second is the GPIO flags.
> @@ -67,6 +68,7 @@ GPIO0 |       gpio_in, gpio_out, ldo, adc
>  GPIO1  |       gpio_in, gpio_out, ldo, adc
>  GPIO2  |       gpio_in, gpio_out
>
> +axp803
>  axp813
>  ------
>  GPIO   |       Functions
> --

As mentioned in my reply to the cover letter, this patch isn't needed.

We ask people to add model-specific compatibles in the device tree
in case the hardware turns out not to be so compatible with the old
hardware we thought it was compatible with. With the model-specific
compatible in place, we have a way out. Without it, we'd have to ask
everyone to update their device trees, which annoys some people who'd
like to have some sort of backward compatibility.

If the model-specific + fallback compatibles combination was to be
listed, the line would include both compatibles. But we're not doing
that for Allwinner stuff. As mentioned it is there just in case. The
best outcome is we don't care and don't need to use them.

ChenYu

  parent reply	other threads:[~2018-10-31  3:01 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 18:53 [PATCH v5 00/11] AXP8x3 AC and battery power supply support Oskari Lemmela
2018-10-23 18:53 ` [PATCH v5 01/11] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding Oskari Lemmela
2018-10-23 18:53 ` [PATCH v5 02/11] dt-bindings: power: supply: axp20x: add AXP803 power bindings Oskari Lemmela
2018-10-24 13:55   ` Rob Herring
2018-10-31  2:38   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 03/11] dt-bindings: gpio: gpio-axp209: add AXP803 GPIO bindings Oskari Lemmela
2018-10-24 13:55   ` Rob Herring
2018-10-31  3:00   ` Chen-Yu Tsai [this message]
2018-10-23 18:53 ` [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings Oskari Lemmela
2018-10-24 13:56   ` Rob Herring
2018-10-28 15:40     ` Jonathan Cameron
2018-10-29 13:07       ` Quentin Schulz
2018-10-31  2:29         ` Chen-Yu Tsai
2018-11-03 10:21           ` Jonathan Cameron
2018-11-05  5:47             ` Chen-Yu Tsai
2018-11-11 15:30               ` Jonathan Cameron
2018-10-23 18:53 ` [PATCH v5 05/11] ARM: dts: axp81x: add AC power supply subnode Oskari Lemmela
2018-10-23 18:53 ` [PATCH v5 06/11] arm64: dts: allwinner: axp803: add AC and battery power supplies Oskari Lemmela
2018-10-31  3:04   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 07/11] arm64: dts: allwinner: a64: sopine-baseboard: enable " Oskari Lemmela
2018-10-31  3:05   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 08/11] arm64: dts: allwinner: a64: pinebook: " Oskari Lemmela
2018-10-31  3:05   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 09/11] power: supply: add AC power supply driver for AXP813 Oskari Lemmela
2018-10-25 10:23   ` Lee Jones
2018-10-31  2:55   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 10/11] mfd: axp20x: Add AC power supply cell " Oskari Lemmela
2018-10-25 10:23   ` Lee Jones
2018-10-23 18:53 ` [PATCH v5 11/11] mfd: axp20x: Add supported cells for AXP803 Oskari Lemmela
2018-10-25 10:24   ` Lee Jones
2018-10-25 13:30 ` [PATCH v5 00/11] AXP8x3 AC and battery power supply support Sebastian Reichel
2018-10-31  2:33   ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v666Vn_GdFwT4MXfbD7Gb1UC+gwGdVhquKH09Ld_Q3QmtA@mail.gmail.com \
    --to=wens@csie.org \
    --cc=anarsoul@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=oskari@lemmela.net \
    --cc=quentin.schulz@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --subject='Re: [PATCH v5 03/11] dt-bindings: gpio: gpio-axp209: add AXP803 GPIO bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).